Fix all examples to run either from root or in examples dir #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed all errors in examples that were due to out dated code (pandas issues with options and indexing). Also fixed it so that all the paths that use git-pandas as the repo do it in a way that they can be ran inside the examples directory or at the root directory. Part of doing this was to better setup the setup.py file. All the requirements are now in the setup.py, and the requirements.txt file says to `-e .` so that it install git-pandas in the local envirornment in editable mode. The normal reccomended way for package development. And then also added an optional extra dependencies section and added examples dependencies like matplotlib, so you can install those by going pip isntall git-pandas[examples]. Also added a requirements-dev.txt which installs the requirements.txt, but also the optional extra dependencies, so you can do things like run the examples.
|
Looks great, thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all errors in examples that were due to out dated code (pandas
issues with options and indexing). Also fixed it so that all the paths
that use git-pandas as the repo do it in a way that they can be ran
inside the examples directory or at the root directory. Part of doing
this was to better setup the setup.py file. All the requirements are now
in the setup.py, and the requirements.txt file says to
-e .so that itinstall git-pandas in the local envirornment in editable mode. The
normal reccomended way for package development. And then also added an
optional extra dependencies section and added examples dependencies like
matplotlib, so you can install those by going pip isntall
git-pandas[examples]. Also added a requirements-dev.txt which installs
the requirements.txt, but also the optional extra dependencies, so you
can do things like run the examples.