Add .activate, .deactivate, .offload helpers to collection.tenants
#311
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
|
Great to see you again! Thanks for the contribution. |
| activate: (tenant: string | TenantBase) => { | ||
| return update({ | ||
| name: parseStringOrTenant(tenant), | ||
| activityStatus: 'ACTIVE', | ||
| }); | ||
| }, | ||
| deactivate: (tenant: string | TenantBase) => { | ||
| return update({ | ||
| name: parseStringOrTenant(tenant), | ||
| activityStatus: 'INACTIVE', | ||
| }); | ||
| }, | ||
| offload: (tenant: string | TenantBase) => { | ||
| return update({ | ||
| name: parseStringOrTenant(tenant), | ||
| activityStatus: 'OFFLOADED', | ||
| }); |
There was a problem hiding this comment.
Do you think it'll make sense to accept (string | TenantBC)[] to match update signature?
There was a problem hiding this comment.
By having it be TenantBase, any of the TenantX types are acceptable in this method since the activityStatus is ignored by the methods; all that is relevant is the name which is the only field of TenantBase
There was a problem hiding this comment.
Should've made it clearer in the original comment: I think these helper methods can accept an array of tenant names, so as to make it possible to, e.g., activate multiple tenants at once.
Just like it's possible to batch-update them.
| activate: (tenant: string | TenantBase) => { | ||
| return update({ | ||
| name: parseStringOrTenant(tenant), | ||
| activityStatus: 'ACTIVE', | ||
| }); | ||
| }, | ||
| deactivate: (tenant: string | TenantBase) => { | ||
| return update({ | ||
| name: parseStringOrTenant(tenant), | ||
| activityStatus: 'INACTIVE', | ||
| }); | ||
| }, | ||
| offload: (tenant: string | TenantBase) => { | ||
| return update({ | ||
| name: parseStringOrTenant(tenant), | ||
| activityStatus: 'OFFLOADED', | ||
| }); |
There was a problem hiding this comment.
Should've made it clearer in the original comment: I think these helper methods can accept an array of tenant names, so as to make it possible to, e.g., activate multiple tenants at once.
Just like it's possible to batch-update them.
| * @returns {Promise<Tenant[]>} The activated tenant as a list of Tenant. | ||
| */ | ||
| activate: (tenant: string | TenantBase) => Promise<Tenant[]>; |
There was a problem hiding this comment.
note: the activated tenant as a list of Tenant looks a tad contrived, since we already know there will only be 1 result in that list.
I'd have these methods accept a (string | TenantBase)[] as per the comment above (or below)
No description provided.