Skip to content

Deprecate min_occurrences and add limit to Metrics.text #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

databyjp
Copy link
Contributor

@databyjp databyjp commented Jul 22, 2025

Addresss #1269, by adding limit parameter, and indicating min_occurrences as deprecated.

Further context: https://weaviate-org.slack.com/archives/C04LB3DLSSG/p1753182544533929

Example usage & deprecation indication:

image

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (4366849) to head (6863e9a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/collections/classes/aggregate.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1756   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         269      269           
  Lines       18724    18738   +14     
=======================================
+ Hits        16354    16367   +13     
- Misses       2370     2371    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@databyjp databyjp marked this pull request as ready for review July 22, 2025 15:03
@databyjp databyjp requested a review from dirkkul July 22, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants