Skip to content

perf: align number hash algorithm with webpack #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nilptr
Copy link
Contributor

@nilptr nilptr commented Jun 11, 2025

Summary

close #10614

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 521aade
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/688c2a872779cb0008ee7097

Copy link

codspeed-hq bot commented Jun 11, 2025

CodSpeed Performance Report

Merging #10643 will not alter performance

Comparing nilptr:nilptr/chore/align-number-hash-algorithm-with-webpack (521aade) with main (46f441d)1

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

Footnotes

  1. No successful run was found on main (e669218) during the generation of this report, so 46f441d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@CPunisher
Copy link
Contributor

🤔 Is this a breaking change cc @hardfist

@CPunisher CPunisher self-assigned this Jul 28, 2025
@CPunisher CPunisher changed the title chore: align number hash algorithm with webpack perf: align number hash algorithm with webpack Jul 31, 2025
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Jul 31, 2025
@CPunisher CPunisher force-pushed the nilptr/chore/align-number-hash-algorithm-with-webpack branch from 2341d79 to a1e4199 Compare July 31, 2025 13:12
Copy link
Contributor

github-actions bot commented Aug 1, 2025

📝 Benchmark detail: Open

Name Base (2025-08-01 e669218) Current Change
10000_big_production-mode_disable-minimize + exec 30.3 s ± 562 ms 30.9 s ± 1.25 s +1.88 %
10000_development-mode + exec 1.79 s ± 27 ms 1.76 s ± 96 ms -1.58 %
10000_development-mode_hmr + exec 691 ms ± 8.5 ms 694 ms ± 22 ms +0.30 %
10000_production-mode + exec 1.85 s ± 43 ms 1.81 s ± 16 ms -2.00 %
10000_production-mode_persistent-cold + exec 1.99 s ± 38 ms 2.02 s ± 254 ms +1.60 %
10000_production-mode_persistent-hot + exec 1.45 s ± 22 ms 1.44 s ± 31 ms -0.75 %
arco-pro_development-mode + exec 1.77 s ± 72 ms 1.77 s ± 63 ms +0.23 %
arco-pro_development-mode_hmr + exec 366 ms ± 0.69 ms 366 ms ± 0.65 ms +0.16 %
arco-pro_production-mode + exec 3.32 s ± 138 ms 3.31 s ± 144 ms -0.29 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.36 s ± 79 ms 3.38 s ± 128 ms +0.33 %
arco-pro_production-mode_persistent-cold + exec 3.35 s ± 56 ms 3.39 s ± 172 ms +1.11 %
arco-pro_production-mode_persistent-hot + exec 2.1 s ± 35 ms 2.04 s ± 57 ms -2.80 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.32 s ± 89 ms 3.34 s ± 39 ms +0.60 %
large-dyn-imports_development-mode + exec 1.96 s ± 24 ms 1.97 s ± 55 ms +0.53 %
large-dyn-imports_production-mode + exec 1.99 s ± 26 ms 2.02 s ± 66 ms +1.82 %
threejs_development-mode_10x + exec 1.51 s ± 21 ms 1.53 s ± 30 ms +1.38 %
threejs_development-mode_10x_hmr + exec 916 ms ± 17 ms 920 ms ± 11 ms +0.43 %
threejs_production-mode_10x + exec 4.67 s ± 197 ms 4.69 s ± 153 ms +0.50 %
threejs_production-mode_10x_persistent-cold + exec 4.8 s ± 132 ms 4.81 s ± 182 ms +0.21 %
threejs_production-mode_10x_persistent-hot + exec 4.21 s ± 198 ms 4.22 s ± 23 ms +0.20 %
10000_big_production-mode_disable-minimize + rss memory 9692 MiB ± 246 MiB 9646 MiB ± 95.2 MiB -0.47 %
10000_development-mode + rss memory 686 MiB ± 17.1 MiB 713 MiB ± 50.6 MiB +3.91 %
10000_development-mode_hmr + rss memory 838 MiB ± 37.3 MiB 858 MiB ± 37.3 MiB +2.38 %
10000_production-mode + rss memory 662 MiB ± 36.4 MiB 692 MiB ± 27.5 MiB +4.48 %
10000_production-mode_persistent-cold + rss memory 762 MiB ± 24.3 MiB 809 MiB ± 40.9 MiB +6.22 %
10000_production-mode_persistent-hot + rss memory 749 MiB ± 57.8 MiB 762 MiB ± 19.5 MiB +1.76 %
arco-pro_development-mode + rss memory 633 MiB ± 22.7 MiB 654 MiB ± 36.6 MiB +3.42 %
arco-pro_development-mode_hmr + rss memory 518 MiB ± 17.3 MiB 527 MiB ± 37.5 MiB +1.74 %
arco-pro_production-mode + rss memory 746 MiB ± 56.7 MiB 716 MiB ± 105 MiB -4.03 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 761 MiB ± 58.2 MiB 738 MiB ± 49.1 MiB -3.03 %
arco-pro_production-mode_persistent-cold + rss memory 811 MiB ± 45.3 MiB 831 MiB ± 107 MiB +2.56 %
arco-pro_production-mode_persistent-hot + rss memory 694 MiB ± 90.8 MiB 678 MiB ± 40.6 MiB -2.20 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 729 MiB ± 37.8 MiB 736 MiB ± 120 MiB +0.96 %
large-dyn-imports_development-mode + rss memory 731 MiB ± 10.9 MiB 734 MiB ± 21.6 MiB +0.49 %
large-dyn-imports_production-mode + rss memory 635 MiB ± 5.22 MiB 660 MiB ± 10.2 MiB +3.97 %
threejs_development-mode_10x + rss memory 680 MiB ± 26.2 MiB 687 MiB ± 18.3 MiB +0.97 %
threejs_development-mode_10x_hmr + rss memory 869 MiB ± 49.5 MiB 896 MiB ± 16.8 MiB +3.10 %
threejs_production-mode_10x + rss memory 842 MiB ± 203 MiB 876 MiB ± 194 MiB +4.13 %
threejs_production-mode_10x_persistent-cold + rss memory 878 MiB ± 22.7 MiB 877 MiB ± 20.4 MiB -0.12 %
threejs_production-mode_10x_persistent-hot + rss memory 731 MiB ± 54.5 MiB 727 MiB ± 41 MiB -0.58 %

@CPunisher CPunisher requested review from CPunisher and removed request for LingyuCoder August 1, 2025 03:20
@CPunisher
Copy link
Contributor

We can merge it first, and optimize it in the future. Also we can submit the optimal algorithm to webpack.

@CPunisher CPunisher merged commit c22b96a into web-infra-dev:main Aug 1, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: get_number_hash add with overflow in 32bit arch
3 participants