-
Notifications
You must be signed in to change notification settings - Fork 11
Closed
Labels
Description
It works (npm start
)!
What still needs to be done:
-
webpack.dist.js
is not fully fleshed out yet... we'll need to tweak things a bit in order to easily consume from the main repo. - review and tweak the rest of the configuration, I started it out with what I think is a good boilerplate for a react project but we can tweak it however.
- refactoring, especially in the
Wrapper.jsx
which essentially contains the whole hierarchy. This has a hugerender
method which contains a lot of room for improvement (e.g. breaking a lot out into separate components, refactoring and removing inline callback functions, etc.)
Some nice potential additions that may be helpful going forward:
- maybe react-hot-loader for a nicer development workflow
- use automatic changelog generation and releasing as outlined in this pr
- use postcss/cssnext and no sass? CSSNext contains many of the features sass does and has the benefit of actually forcing us to be compliant with what will be supported soon. Plus we're already using postcss for the auto-prefixing so this would allow for just a simpler configuration in general.
I'll create a separate issue for the redesign but I think we should do a little more cleanup first. @NejcZdovc @pksjce or anyone else interested in helping to refactor, please just let me know what you want to tackle and I'll leave that section alone.