Skip to content

HMR logging info message when clientLogLevel is not set to info #1195

@josh18

Description

@josh18
  • Operating System: Windows
  • Node Version: 8.8.1
  • NPM Version: 5.4.2
  • webpack Version: 3.8.1
  • webpack-dev-server Version: 2.9.4
  • This is a bug
  • This is a feature request
  • This is a modification request

Code

// webpack.config.js
...
devServer: {
    clientLogLevel: 'warning',
    hot: true
}
...

Expected Behavior

HMR info messages are not logged unless clientLogLevel is set to info.

Actual Behavior

The info message [HMR] Waiting for update signal from WDS... is always logged. Other logged messages work correctly.


I believe this is caused by the log-level socket (which sets HMR log level) happening after the message is logged (location where it is logged)

I'm not sure how this would be fixed but I'm happy to open a PR if someone has a solution and it isn't too difficult.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions