docs(configuration): fix typo in devServer.onListening usage
#5310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/Fd3ZW8hDz6wKh8KhqB8iAZ3LnbCP |
snitin315
commented
Aug 19, 2021
chenxsan
reviewed
Aug 20, 2021
| onListening: function (server) { | ||
| const port = server.address().port; | ||
| onListening: function (devServer) { | ||
| const port = devServer.server.address().port; |
There was a problem hiding this comment.
Should we check the existence of devServer first? https://github.com/webpack/webpack-dev-server/blob/974ce25669ef6a4f55e8a7576fc140bc7ccb55f1/test/server/onListening-option.test.js#L18
There was a problem hiding this comment.
Not sure, it is unlikely to be undefined. But no harm in checking.
There was a problem hiding this comment.
/cc @alexander-akait what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be
server.server.address()