Skip to content

UI-LIB scrollview fix for new arch #3775 #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

UI-LIB scrollview fix for new arch #3775 #3776

merged 2 commits into from
Jul 10, 2025

Conversation

markdevocht
Copy link

@markdevocht markdevocht commented Jul 9, 2025 •
edited by M-i-k-e-l
Loading

Description

Fixing the KeyboardTrackingViewTemp object in KeyboardTrackingViewTempManager.m to comply with rn77 new arch.

KeyboardTrackingViewTempManager.m contains the following changes:

  • -(RCTRootView*)getRootView is converted to return a RCTSurfaceHostingView as rootView
  • addObserver:self forKeyPath:@"bounds" is changed to "frame" because the fabric architecture's layout engine updates the "frame" when layout changes occur. The "bounds" was only called once and prematurely.
  • Changes done in - (void)initializeAccessoryViewsAndHandleInsets to handle the ScrollView components according to new arch where it is wrapped in the RCTScrollViewComponentView class.

Changelog

Fix KeyboardTrackingView

@markdevocht markdevocht requested review from gosha212 and M-i-k-e-l July 9, 2025 13:38
@gosha212 gosha212 requested a review from artald July 9, 2025 17:50
gosha212
gosha212 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@gosha212 gosha212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@M-i-k-e-l M-i-k-e-l marked this pull request as ready for review July 10, 2025 11:13
@M-i-k-e-l M-i-k-e-l merged commit b510acf into rn77-new-arch-fixes-2 Jul 10, 2025
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the bugfix/UI-LIB-scrollview-fix-for-new-arch branch July 10, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosha212 gosha212 gosha212 approved these changes

@M-i-k-e-l M-i-k-e-l Awaiting requested review from M-i-k-e-l

@artald artald Awaiting requested review from artald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdevocht @gosha212 @M-i-k-e-l