Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

Fix some Promise.reject not being returned in FileSystem #366

Merged
merged 1 commit into from
May 26, 2017
Merged

Fix some Promise.reject not being returned in FileSystem #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ function writeFile(path:string, data:string | Array<number>, encoding:?string):P
return Promise.reject('Invalid argument "path" ')
if(encoding.toLocaleLowerCase() === 'ascii') {
if(!Array.isArray(data))
Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
return Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
else
return RNFetchBlob.writeFileArray(path, data, false);
} else {
if(typeof data !== 'string')
Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
return Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
else
return RNFetchBlob.writeFile(path, encoding, data, false);
}
Expand All @@ -188,12 +188,12 @@ function appendFile(path:string, data:string | Array<number>, encoding:?string):
return Promise.reject('Invalid argument "path" ')
if(encoding.toLocaleLowerCase() === 'ascii') {
if(!Array.isArray(data))
Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
return Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
else
return RNFetchBlob.writeFileArray(path, data, true);
} else {
if(typeof data !== 'string')
Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
return Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
else
return RNFetchBlob.writeFile(path, encoding, data, true);
}
Expand Down