Circular references in typing

[seriema]

We use dts-bundle-generator and running dts-bundle-generator --out-file dist/bundle.d.ts src/main.ts results in errors around circular dependencies in the types:

../../node_modules/cnbuilder/dist/types.d.ts(1,21): error TS2456: Type alias 'ClassValue' circularly references itself.
19:07:34
../../node_modules/cnbuilder/dist/types.d.ts(2,21): error TS2456: Type alias 'ClassListArray' circularly references itself.

[xobotyi]

That one is unfixable.
Since cnb supports any level of nesting (array-wise) there is no other way to type it without circular types.

[xobotyi]

Weel it is actually fixable in case i'll change the behaviour and make only one level of array nesting possible.
Because i've made the library to be a drop-in replacement of classnames, which supports any level of array nesting, i've left that behavior, but if judge sanity-wise - there is no sence: i've never had nested array-classlist for last 3 years im using classnames building libraries.

[seriema]

Looks like typing circular references came in TS 3.7 microsoft/TypeScript#33050 Some other ways https://stackoverflow.com/questions/36966444/how-to-create-a-circularly-referenced-type-in-typescript

…

On 8 Nov 2020, at 20:14, Anton Zinovyev ***@***.***> wrote:  Weel it is actually fixable in case i'll change the behaviour and make only one level of array nesting possible. Because i've made the library to be a drop-in replacement of classnames, which supports any level of array nesting, i've left that behavior, but if judge sanity-wise - there is no sence: i've never had nested array-classlist for last 3 years im using classnames building libraries. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[seriema]

Silly me, I should have checked dts-bundle-generator first. It was outdated and using a lower version of TypeScript (3.6.2, that didn't have circular reference support). Upgrading fixed the issue.