Remove usingnamespace usage, build script fixups, and support linking memory allocation functions from a shared library #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion functions from a shared library with the -msvc ABI
- Fixup build script / callconv deprecations
There was a problem hiding this comment.
Pull Request Overview
This PR updates the zmesh library to be compatible with Zig 0.15.x by removing deprecated usingnamespace usage and updating build script patterns. The changes also add support for linking memory allocation functions from shared libraries when using the MSVC ABI.
Key changes include:
- Elimination of
usingnamespacein favor of direct imports and function definitions - Migration from deprecated
.Ccalling convention to.c - Implementation of new
@externfield syntax with.is_dll_importfor shared library compatibility - Build script modernization and alignment handling updates
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/zcgltf.zig | Adds direct function implementations and updates calling conventions from .C to .c |
| src/memory.zig | Replaces extern variable declarations with @extern syntax and updates alignment handling |
| src/io.zig | Removes usingnamespace usage by replacing wrapper struct with direct import |
| build.zig | Modernizes build script by consolidating library creation and updating module configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5.
As of 0.15.x
usingnamespacehas been removed: ziglang/zig#20663Changes:
.is_dll_import, to allow linking the memory allocation functions from a shared library when using the-msvcABI