atomic fixes and clarification #24278
Merged
+42
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gooncreeper
force-pushed
the
atomic-fixes
branch
from
032db98 to
6956466
Compare
Additionally, disable failing big-endian atomic test also improve test paramaters to catch this when condition is removed also some other cleanups
also fix the struct test
Floats are not allowed in @cmpxchg Packed structs are allowed for all atomic builtins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the lowering of packed structs with non-power-of-two backing integers in the LLVM backend; previously LLVM would throw the error "
atomic memory access' operand must have a power-of-two size". Additionally, error sets are now caught when used in atomic instructions. Furthermore, I clarified the langref on which types are allowed in atomic builtins.