Skip to content

PR 343 review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

PR 343 review #1

merged 1 commit into from
Oct 1, 2018

Conversation

fpistm
Copy link

@fpistm fpistm commented Oct 1, 2018

Hi @zoomx
I've made a quick review and do some update:

  • Remove trailing space
  • Unify file format (Unix)
  • Add STM Morpho connector pin mapping
  • Clean up some comments

If you are agreed, could you squash all your commits for the L073 and this one into one commit then force update to your branch to update stm32duino#343
Thanks

Remove trailing space
Unify file format (Unix)
Add STM Morpho connector pin mapping
Clean up some comments

Signed-off-by: Frederic.Pillon <[email protected]>
@zoomx zoomx merged commit 2bd8339 into zoomx:master Oct 1, 2018
@fpistm
Copy link
Author

fpistm commented Oct 1, 2018

Merci

@fpistm fpistm deleted the PR-343-review branch October 1, 2018 15:50
@zoomx
Copy link
Owner

zoomx commented Oct 1, 2018

I agree, of course, and merged it but I don't know how to force update to my branch!

@fpistm
Copy link
Author

fpistm commented Oct 1, 2018

No worries, I will squash the 3 commits in one when I will merge your PR. ;)

@zoomx
Copy link
Owner

zoomx commented Oct 1, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants