-
Notifications
You must be signed in to change notification settings - Fork 3k
Use toolchain's struct stat if available #12607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes arduino/ArduinoCore-nRF528x-mbedos#49 The patch should be as safe as possible, since __has_include is guarded itself.
@facchinm, thank you for your changes. |
Seems reasonable to me. I wasn't aware GCC supported |
@kjbracey-arm if you have looked at this and are happy could you approve please ? |
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
tests restarted |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
Summary of changes
Include
<sys/stat.h>
(if it's available ) to providestruct stat
.Fixes arduino/ArduinoCore-nRF528x-mbedos#49
The patch should be as safe as possible, since
__has_include
is guarded itself.Impact of changes
Adds
sizeof(dev_t)
on every instance since GCC defines it asand
dev_t st_rdev;
is not part of mbed's struct.Migration actions required
Documentation
None
Pull request type
Test results
Only tested on GCC_ARM, hope the CI helps with the other targets.
Reviewers