Skip to content

Fix sys/stat.h issue for unit tests on macOS #14402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix sys/stat.h issue for unit tests on macOS #14402

merged 1 commit into from
Mar 11, 2021

Conversation

ladislas
Copy link
Contributor

@ladislas ladislas commented Mar 10, 2021 •
edited
Loading

Summary of changes

On macOS clang tries to use Xcode's stat.h and everything fails.

This PR does the same as #12607 but for unit tests on macOS.

Impact of changes

none

Migration actions required

none

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 10, 2021
@ciarmcom
Copy link
Member

@ladislas, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 10, 2021 10:00
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Mar 11, 2021
@mbed-ci
Copy link

mbed-ci commented Mar 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@ladislas
Copy link
Contributor Author

Wow! CI seems much faster now!

@0xc0170 0xc0170 merged commit 1712f66 into ARMmbed:master Mar 11, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2021

FYI @rajkan01 If you rebase feature unit test branch, this might be a conflict

@mergify mergify bot removed the ready for merge label Mar 11, 2021
This was referenced Mar 12, 2021
Closed
Closed
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: test release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ladislas @ciarmcom @0xc0170 @mbed-ci @mbedmain