Support arbitrary storage alongside WiFi firmware in external storage on Cypress targets #13436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 13, 2020 11:15
In some toolchains, in order to use linker symbols referring to the start and end of a region, the region name must not contain a '.' character. These changes allow those symbols to be used for the cy_xip region by renaming it. They also create explicit start and end symbols for GCC.
…d using linker symbols If the macro CY_STORAGE_WIFI_DATA_OUTPUT is defined, its value is used as the name of the WiFi firmware storage region to determine the start and end of.
…assed in This allows the use of a different resource, buffer, or network interface from the default when performing WiFi initialization.
Given an underlying block device and the size of the reserved region, a CyReservedRegionBlockDevice will act as the underlying block device but operating only outside of the reserved region. It also allows reading from the reserved region. The reserved region is assumed to start at address 0 in the underlying block device.
…Cypress WiFi firmware in external memory This change allows external memory to be used for other purposes while the WiFi firmware is stored in it by interacting with it via the reserved region block device.
…Fi firmware Targets that inherit from this target will have the defines necessary to place the WiFi firmware in external storage and enable use of the external WiFi firmware reserved region block device. Currently, the only target inheriting from this new target is CY8CPROTO-062S3-4343W.
|
@matthew-macovsky-cypress, thank you for your changes. |
you can use WIP: in the title. I'll mark it as such now. |
|
This still WIP? |
|
The current plan is for this to remain WIP until upcoming Cypress asset releases. Once those releases are merged, the changes to those assets will be removed from this PR and it will be unmarked as WIP. |
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
|
If we are going to wait longer, it might be better to close this and reopen once it is ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: DO NOT MERGE YET
Summary of changes
This change allows for the remainder of external storage to be used for other purposes when the Cypress WiFi firmware is stored in part of it.
Previously on Cypress targets, when the WiFi firmware was stored in external storage, XIP mode would be used to access the firmware. This mode is exclusive with the MMIO mode, preventing the use of QSPI and therefore also preventing the use of a KVStore or a file system in external storage. This change allows the firmware to be read using QSPI and thus allows those storage mechanisms to work alongside it.
Impact of changes
The target CY8CPROTO_062S3_4343W will now use this mechanism by default rather than using XIP.
Documentation
None
Pull request type
Test results
GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_P6S1_43438EVB_01_GCC.txt
GT_FT_PROTO_062S3_4343W.txt
GT_FT_PROTO_062_4343W_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
The failures seen are known pre-existing issues.
Reviewers
@ARMmbed/team-cypress