Support arbitrary storage alongside WiFi firmware in external storage on Cypress targets #14063

dustin-crossman · 2020-12-17T00:48:01Z

Summary of changes

This change allows for the remainder of external storage to be used for other purposes when the Cypress WiFi firmware is stored in part of it.

This contains the same changes as #13436 and has been rebased and updated to the current master.

Note: This PR has been tested with the changes from, and is dependent on: #14062

Impact of changes

Migration actions required

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

GT_FT_P6S1_43438EVB_01_GCC_NET.txt
GT_FT_PROTO_062_4343W_GCC.txt
GT_FT_PROTO_062S3_4343W.txt
GT_FT_PROTO_062S3_4343W_GCC_NET.txt
GT-FT-KIT_062_WIFI_BT-GCC-NET.txt
GT-FT-KIT-062S2-43012-GCC-NET.txt
GT-FT-PROT-062-4343W-GCC-NET.txt
GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC_NET.txt
GT_FT_P6S1_43438EVB_01_GCC.txt

Test Failures and Explanations:

connectivity-feature_ble-source-cordio-tests-cordio_hci-driver on multiple boards: Known failure. Fixed in PR: ble cyw43xxx: dev/hci driver terminate #14009
storage-blockdevice-tests-tests-blockdevice-general_block_device on multiple boards: Fails on master. Will investigate.
connectivity-netsocket-tests-tests-network-wifi on CY8CKIT-062S2-43012: Intermittent failure. Passes when run manually.

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

In some toolchains, in order to use linker symbols referring to the start and end of a region, the region name must not contain a '.' character. These changes allow those symbols to be used for the cy_xip region by renaming it. They also create explicit start and end symbols for GCC.

Given an underlying block device and the size of the reserved region, a CyReservedRegionBlockDevice will act as the underlying block device but operating only outside of the reserved region. It also allows reading from the reserved region. The reserved region is assumed to start at address 0 in the underlying block device.

…Cypress WiFi firmware in external memory This change allows external memory to be used for other purposes while the WiFi firmware is stored in it by interacting with it via the reserved region block device.

…Fi firmware Targets that inherit from this target will have the defines necessary to place the WiFi firmware in external storage and enable use of the external WiFi firmware reserved region block device. Currently, the only target inheriting from this new target is CY8CPROTO-062S3-4343W.

ciarmcom · 2020-12-17T01:00:24Z

@dustin-crossman, thank you for your changes.
@ARMmbed/team-cypress @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

targets/TARGET_Cypress/TARGET_PSOC6/common/ext-wifi-fw/cy_ext_wifi_fw_resources.c

targets/TARGET_Cypress/TARGET_PSOC6/common/reserved-region-bd/CyReservedRegionBlockDevice.cpp

evedon

Apart from the suggestion, the code change looks fine but the test failures should be investigated and fixed. Do you have an update on:

storage-blockdevice-tests-tests-blockdevice-general_block_device on multiple boards: Fails on master.
connectivity-netsocket-tests-tests-network-wifi on CY8CKIT-062S2-43012: Intermittent failure. Passes when run manually.

targets/TARGET_Cypress/TARGET_PSOC6/common/reserved-region-bd/CyReservedRegionBlockDevice.cpp

Pull request has been modified.

dustin-crossman · 2021-01-05T21:58:55Z

@evedon The wifi test failure is, I believe, just due to some reliability issues in our test setup. As for the general_block_device fail I don't have any updates but we will definitely look into it and address in the future.

evedon · 2021-01-08T09:45:07Z

@evedon The wifi test failure is, I believe, just due to some reliability issues in our test setup. As for the general_block_device fail I don't have any updates but we will definitely look into it and address in the future.

It would be better to fix the general_block_device issue now. Can you turn on verbosity to show what the error is?

dustin-crossman · 2021-01-13T05:09:04Z

@evedon I'm working on the fix for the general_block_device now.

…ut free.

dustin-crossman · 2021-01-14T22:03:36Z

@evedon general_block_device test issues fixed!

evedon

Great! Thanks

0xc0170 · 2021-01-15T14:28:00Z

CI started

mbed-ci · 2021-01-15T18:14:20Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

ifyall · 2021-01-15T18:52:25Z

@0xc0170, I can't find the failure log for the greentea-test. When I follow the "Logs & Artifacts" link and drill down to greentea-test, I find a directory which only has PASS logs: http://mbed-os-ci-public.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-14063/artifacts/14063/1/greentea-test/4938/

Can you provide the appropriate logs?

Thanks,

Ian

0xc0170 · 2021-01-18T09:15:11Z

Networking issue, I am restarting CI now

mbed-ci · 2021-01-19T23:05:19Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

Matthew Macovsky added 4 commits December 16, 2020 15:30

Create canonical CyReservedRegionBlockDevice for working with/around …

fc70273

…Cypress WiFi firmware in external memory This change allows external memory to be used for other purposes while the WiFi firmware is stored in it by interacting with it via the reserved region block device.

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 17, 2020

ciarmcom requested review from a team December 17, 2020 01:00

ciarmcom added the needs: review label Dec 17, 2020

evedon requested review from evedon and removed request for a team December 17, 2020 15:05

ifyall approved these changes Jan 4, 2021

View reviewed changes

0xc0170 previously requested changes Jan 5, 2021

View reviewed changes

targets/TARGET_Cypress/TARGET_PSOC6/common/ext-wifi-fw/cy_ext_wifi_fw_resources.c Outdated Show resolved Hide resolved

targets/TARGET_Cypress/TARGET_PSOC6/common/reserved-region-bd/CyReservedRegionBlockDevice.cpp Outdated Show resolved Hide resolved

mergify bot added needs: work and removed needs: review labels Jan 5, 2021

evedon reviewed Jan 5, 2021

View reviewed changes

targets/TARGET_Cypress/TARGET_PSOC6/common/reserved-region-bd/CyReservedRegionBlockDevice.cpp Outdated Show resolved Hide resolved

dustin-crossman added 2 commits January 5, 2021 13:50

Addressing review feedback.

782b23d

Ran astyle for mbed code format.

82c9861

dustin-crossman added 2 commits January 14, 2021 12:58

Implement qspi_frequency for Cypress Mbed HAL.

95a5d60

Added process to reinitialize qspi if qspi_init is called twice witho…

ef6284c

…ut free.

evedon approved these changes Jan 15, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Jan 15, 2021

mergify bot added ready for merge and removed needs: CI labels Jan 19, 2021

0xc0170 merged commit 8effecd into ARMmbed:master Jan 20, 2021

mergify bot removed the ready for merge label Jan 20, 2021

mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support arbitrary storage alongside WiFi firmware in external storage on Cypress targets #14063

Support arbitrary storage alongside WiFi firmware in external storage on Cypress targets #14063

Uh oh!

dustin-crossman commented Dec 17, 2020

Uh oh!

ciarmcom commented Dec 17, 2020

Uh oh!

Uh oh!

Uh oh!

evedon left a comment

Uh oh!

Uh oh!

dustin-crossman commented Jan 5, 2021

Uh oh!

evedon commented Jan 8, 2021

Uh oh!

dustin-crossman commented Jan 13, 2021

Uh oh!

dustin-crossman commented Jan 14, 2021

Uh oh!

evedon left a comment

Uh oh!

0xc0170 commented Jan 15, 2021

Uh oh!

mbed-ci commented Jan 15, 2021

Uh oh!

ifyall commented Jan 15, 2021

Uh oh!

0xc0170 commented Jan 18, 2021

Uh oh!

mbed-ci commented Jan 19, 2021

Uh oh!

Uh oh!

Support arbitrary storage alongside WiFi firmware in external storage on Cypress targets #14063

Support arbitrary storage alongside WiFi firmware in external storage on Cypress targets #14063

Uh oh!

Conversation

dustin-crossman commented Dec 17, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Dec 17, 2020

Uh oh!

Uh oh!

Uh oh!

evedon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dustin-crossman commented Jan 5, 2021

Uh oh!

evedon commented Jan 8, 2021

Uh oh!

dustin-crossman commented Jan 13, 2021

Uh oh!

dustin-crossman commented Jan 14, 2021

Uh oh!

evedon left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 15, 2021

Uh oh!

mbed-ci commented Jan 15, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

ifyall commented Jan 15, 2021

Uh oh!

0xc0170 commented Jan 18, 2021

Uh oh!

mbed-ci commented Jan 19, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

Uh oh!