Introduce AHC RxJava 2.x extras #1391
Conversation
* Main interface is RxHttpClient modelled after AsyncHttpSingle from RxJava 1.x extras * Use Maybe reactive base type instead of Single, since RxJava 2 won't allow emission of null values any longer * Update to RxJava/ReactiveStreams terminology (i.e. "unsubscribe" became "dispose")
| public DisposedException() { | ||
| } | ||
|
|
||
| public DisposedException(final Throwable cause) { |
There was a problem hiding this comment.
Yep, just like in the RxJava1 extras. It's just a convenience thingy when someone wants to use/extend this stuff. I'll remove it if you prefer...?
| * if at least one of the parameters is {@code null} | ||
| */ | ||
| <T> Maybe<T> prepare(Request request, Supplier<? extends AsyncHandler<T>> handlerSupplier); | ||
|
|
| final T result; | ||
| try { | ||
| result = delegate().onCompleted(); | ||
| } catch (final Throwable t) { |
There was a problem hiding this comment.
Is it really OK to catch Throwable instead of only Exception?
There was a problem hiding this comment.
That's an RxJava pattern found in various places there, e.g. in one of the the map operator implementations. If it's some "fatal" exception from RxJava's point of view, it will be rethrown via io.reactivex.exceptions.Exceptions.throwIfFatal(…) in emitOnError. Everything else will be reported via onError.
| */ | ||
| protected final AsyncHandler.State disposed() { | ||
| if (!delegateTerminated.getAndSet(true)) { | ||
| delegate().onThrowable(new DisposedException()); |
There was a problem hiding this comment.
DisposedException could be turned into a singleton/constant without stacktrace.
|
Done. I opted to do lazy init for the cached |
|
Great work, thanks a lot! |
* Main interface is RxHttpClient modelled after AsyncHttpSingle from RxJava 1.x extras * Use Maybe reactive base type instead of Single, since RxJava 2 won't allow emission of null values any longer * Update to RxJava/ReactiveStreams terminology (i.e. "unsubscribe" became "dispose")
* Main interface is RxHttpClient modelled after AsyncHttpSingle from RxJava 1.x extras * Use Maybe reactive base type instead of Single, since RxJava 2 won't allow emission of null values any longer * Update to RxJava/ReactiveStreams terminology (i.e. "unsubscribe" became "dispose")
* Main interface is RxHttpClient modelled after AsyncHttpSingle from RxJava 1.x extras * Use Maybe reactive base type instead of Single, since RxJava 2 won't allow emission of null values any longer * Update to RxJava/ReactiveStreams terminology (i.e. "unsubscribe" became "dispose")
RxHttpClient, modelled afterAsyncHttpSinglefrom RxJava 1.x extrasMaybereactive base type instead ofSingle, since RxJava 2 won't allow emission ofnullvalues any longer