Skip to content

Backport AHC RxJava 2.x extras to 2.0 #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Apr 20, 2017

Cherry-picked #1391 and d249f56 into the 2.0 branch. Just adjusted the version in the POM.

@slandelle
Copy link
Contributor

@twz123 Could you please fix javadoc: d249f56

* Main interface is RxHttpClient modelled after AsyncHttpSingle from RxJava 1.x extras
* Use Maybe reactive base type instead of Single, since RxJava 2 won't allow emission of null values any longer
* Update to RxJava/ReactiveStreams terminology (i.e. "unsubscribe" became "dispose")
@twz123 twz123 force-pushed the rxjava2-backport-2.0 branch from 6721eab to 3b2506b Compare April 20, 2017 07:37
@twz123
Copy link
Contributor Author

twz123 commented Apr 20, 2017

Ha! Just missed that one ;)

Done.

@slandelle slandelle merged commit 6aaed08 into AsyncHttpClient:2.0 Apr 20, 2017
@slandelle
Copy link
Contributor

Thanks!

@slandelle slandelle added this to the 2.0.32 milestone Apr 20, 2017
@twz123 twz123 deleted the rxjava2-backport-2.0 branch April 20, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants