Added comment to explain disabled function flow #8099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surgupta-msft
changed the title
satvu
approved these changes
Jan 26, 2022
liliankasem
approved these changes
Jan 27, 2022
kshyju
approved these changes
Jan 27, 2022
surgupta-msft
added a commit
that referenced
this pull request
Jul 22, 2022
surgupta-msft
added a commit
that referenced
this pull request
Jul 25, 2022
* Host to fall back on its own indexing if worker denies (#7980) * Added host fall back if worker denies indexing * Added Env in CanWorkerIndex * Calling host if flag useDefaultWorkerIndexing is set to true * Renaming workerFunctionMetadataProvider to AggregateFunctionMetadataProvider * Code cleanup and test fixing * code cleanup and resolving PR comments * Tests * Added tests * Fixing test failures * Code restructuring in AggregateFunctionMetadatProvider * Improved logging and exception * Added method to determine if worker denied indexing * corrected environment variable * Remvoing retry options and config source from proto file in host (#8070) * Sending single load request in case of multiple functions (#8054) * Sending single load request in case of multiple functions. Advertised via capabilities * Adding comment to explain disabled function flow (#8099) * Host to send load request correctly after fallback is requested by the worker (#8200) * fix for hostfallback bug * Added tests * Sending load request * Code refactoring * Added tests * Python sample app update for worker indexing * Refactoring in tests * Worker indexing tests refactoring * variable naming fix * Worker Indexing - Adding log to inform about mixed function app (#8201) * Adding logic to detect mixed app and log it * Added tests * Test logger string * added tests * Tests * Tests refactoring * passing scripthostoptions * Taking scriptpath from scriptJobHostoptions * Added list of legacy functions * Project stein - Adding additional logs and exception handling (#8231) * Added logs and exception handling * minox fixes * Minor improvements in CanWorkerIndex * Mixed app Loglevel setting based on Environment name * Added helper method and its test and link to document * Checking IsCoreTools for logging * Removing customer IsDev method * Adding ability to allow worker to send Function load responses in batch (#8363) * Adding FunctionLoadResponses to send single load response in case of multiple functions * Subscribed to LoadResponseCollection * Updated subtree from https://github.com/azure/azure-functions-language-worker-protobuf. Tag: v1.5.4-protofile. Commit: 576c9de * Removing redundant line * Added failure testcase for LoadRepsonseCollection * Moving event subscription under if else block * Send function outside else block * Tests * Renaming variable * Adding timeout * Cleaning up if-else * Updating protobuf to latest v1.5.8 * Updating logs * Protobuf update * Updating logs in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #8081
Adding comment in code to explain disabled functions flow. Host sends LoadRequest for disabled function as it is invocable using the portal and admin endpoints. We also load disabled functions after enabled functions to avoid unnecessary performance issues. Refer PR #5072.