Skip to content

Project stein - Adding additional logs and exception handling #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 27, 2022

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Mar 14, 2022

PR contains minor changes for Project stein -

  1. Adding logs when receiving FunctionMetadataResponse with failed status and also did changes in tests for it.
  2. In Utility.CanWorkerIndex(), minor change to check feature flag first and return false if it is not enabled.
  3. Replaced WorkerFunctionMetadataProvider by AggregateFunctionMetadataProvider in one of the comments.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@surgupta-msft surgupta-msft marked this pull request as ready for review April 5, 2022 21:56
Copy link
Member

@soninaren soninaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, looks good otherwise.

@surgupta-msft surgupta-msft merged commit 1db1782 into dev Apr 27, 2022
@surgupta-msft surgupta-msft deleted the surgupta/stein-logging branch April 27, 2022 03:30
surgupta-msft added a commit that referenced this pull request Jul 22, 2022
* Added logs and exception handling

* minox fixes

* Minor improvements in CanWorkerIndex

* Mixed app Loglevel setting based on Environment name

* Added helper method and its test and link to document

* Checking IsCoreTools for logging

* Removing customer IsDev method
surgupta-msft added a commit that referenced this pull request Jul 22, 2022
* Added logs and exception handling

* minox fixes

* Minor improvements in CanWorkerIndex

* Mixed app Loglevel setting based on Environment name

* Added helper method and its test and link to document

* Checking IsCoreTools for logging

* Removing customer IsDev method
surgupta-msft added a commit that referenced this pull request Jul 25, 2022
* Host to fall back on its own indexing if worker denies (#7980)

* Added host fall back if worker denies indexing

* Added Env in CanWorkerIndex

* Calling host if flag useDefaultWorkerIndexing is set to true

* Renaming workerFunctionMetadataProvider to AggregateFunctionMetadataProvider

* Code cleanup and test fixing

* code cleanup and resolving PR comments

* Tests

* Added tests

* Fixing test failures

* Code restructuring in AggregateFunctionMetadatProvider

* Improved logging and exception

* Added method to determine if worker denied indexing

* corrected environment variable

* Remvoing retry options and config source from proto file in host (#8070)

* Sending single load request in case of multiple functions (#8054)

* Sending single load request in case of multiple functions. Advertised via capabilities

* Adding comment to explain disabled function flow (#8099)

* Host to send load request correctly after fallback is requested by the worker (#8200)

* fix for hostfallback bug

* Added tests

* Sending load request

* Code refactoring

* Added tests

* Python sample app update for worker indexing

* Refactoring  in tests

* Worker indexing tests refactoring

* variable naming fix

* Worker Indexing - Adding log to inform about mixed function app (#8201)

* Adding logic to detect mixed app and log it

* Added tests

* Test logger string

* added tests

* Tests

* Tests refactoring

* passing scripthostoptions

* Taking scriptpath from scriptJobHostoptions

* Added list of legacy functions

* Project stein - Adding additional logs and exception handling (#8231)

* Added logs and exception handling

* minox fixes

* Minor improvements in CanWorkerIndex

* Mixed app Loglevel setting based on Environment name

* Added helper method and its test and link to document

* Checking IsCoreTools for logging

* Removing customer IsDev method

* Adding ability to allow worker to send Function load responses in batch (#8363)

* Adding FunctionLoadResponses to send single load response in case of multiple functions

* Subscribed to LoadResponseCollection

* Updated subtree from https://github.com/azure/azure-functions-language-worker-protobuf. Tag: v1.5.4-protofile. Commit: 576c9de

* Removing redundant line

* Added failure testcase for LoadRepsonseCollection

* Moving event subscription under if else block

* Send function outside else block

* Tests

* Renaming variable

* Adding timeout

* Cleaning up if-else

* Updating protobuf to latest v1.5.8

* Updating logs

* Protobuf update

* Updating logs in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants