Skip to content

Disable dependency isolation for py 3.10 #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

gavin-aguiar
Copy link
Contributor

Description

Disabling dependency isolation for py 3,10 temporarily to unblock PR. Needs further investigation.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1003 (2f694a7) into dev (8800edd) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

❗ Current head 2f694a7 differs from pull request most recent head 7803694. Consider uploading reports for the commit 7803694 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1003      +/-   ##
==========================================
- Coverage   82.76%   82.46%   -0.30%     
==========================================
  Files          33       33              
  Lines        1677     1677              
  Branches      267      267              
==========================================
- Hits         1388     1383       -5     
- Misses        226      228       +2     
- Partials       63       66       +3     
Flag Coverage Δ
unittests 82.46% <100.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/constants.py 100.00% <100.00%> (ø)
azure_functions_worker/utils/dependency.py 86.46% <0.00%> (-3.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8800edd...7803694. Read the comment docs.

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/disable_dep_iso branch from 896e30e to a68928b Compare April 8, 2022 16:53
@gavin-aguiar gavin-aguiar merged commit 2de202a into dev Apr 8, 2022
@gavin-aguiar gavin-aguiar deleted the gaaguiar/disable_dep_iso branch April 8, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants