Skip to content

Fix test_queue_return flaky test and other nits #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Oct 12, 2022

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1118 (2c04337) into dev (eaa1369) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1118      +/-   ##
==========================================
- Coverage   85.14%   84.46%   -0.69%     
==========================================
  Files          33       33              
  Lines        1845     1834      -11     
  Branches      273      273              
==========================================
- Hits         1571     1549      -22     
- Misses        205      213       +8     
- Partials       69       72       +3     
Flag Coverage Δ
unittests 84.46% <100.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 88.12% <100.00%> (-1.09%) ⬇️
azure_functions_worker/bindings/datumdef.py 68.05% <0.00%> (-4.17%) ⬇️
azure_functions_worker/extension.py 98.13% <0.00%> (-0.96%) ⬇️
azure_functions_worker/constants.py 100.00% <0.00%> (ø)
...ed_memory_data_transfer/shared_memory_constants.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vrdmr vrdmr force-pushed the vameru/fixing-test-queue-return-flaky-test branch 2 times, most recently from b7ad9d1 to 24c71f8 Compare October 17, 2022 15:45
@vrdmr vrdmr force-pushed the vameru/fixing-test-queue-return-flaky-test branch from 24c71f8 to 2c04337 Compare October 17, 2022 16:01
@vrdmr vrdmr merged commit 9289105 into dev Oct 18, 2022
@vrdmr vrdmr deleted the vameru/fixing-test-queue-return-flaky-test branch October 18, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants