Skip to content

build: Add linux-arm64 build #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 8, 2025
Merged

build: Add linux-arm64 build #1677

merged 10 commits into from
May 8, 2025

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented May 2, 2025

Description

Adds linux-arm64 builds.
Note: win-arm64 is not supported because GRPC does not have a win-arm64 build.

Testing fixes:

  • Fixes skipTest variable setting
  • Skips deferred bindings cache tests for 3.13 for now

Pipeline refactoring:

  • Removes CodeQL from release pipeline
  • Refactors pack/ into eng/
  • Refactor workerPath into top-level variables
  • Fixes Python minor version check in env_gen templates

Build fixes:

  • Puts OSX_ARM64 build into OSX/ARM64 folder

Fixes #1643


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria changed the title Build: Add linux-arm64 build build: Add linux-arm64 build May 2, 2025
@@ -28,8 +47,7 @@ steps:
condition: ne(variables['pythonVersion'], '3.7')
- task: CopyFiles@2
inputs:
contents: |
${{ parameters.workerPath }}
contents: '$(workerPath)'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workerPath is set above. For Python 3.12 & under, the path is python/prodV4/worker.py. For 3.13+, it is python/proxyV4/worker.py

@@ -8,36 +8,28 @@ jobs:
matrix:
Python37V4:
pythonVersion: '3.7'
workerPath: 'python/prodV4/worker.py'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the comments from the 3.13 PR was to make workerPath a top-level variable. Since workerPath is different based on 3.13+ and <3.13, it can't be a global variable. The solution was to instead define 2 new global variables: one for the prodv4 path, and one for the proxyv4 path. Then, in the env_gen files, we determine which path to use based on the python version.

@hallvictoria hallvictoria marked this pull request as ready for review May 6, 2025 21:06
@hallvictoria hallvictoria requested a review from vrdmr as a code owner May 6, 2025 21:06
@hallvictoria hallvictoria merged commit a9ce719 into dev May 8, 2025
29 of 31 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/linux-arm64 branch May 8, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package linux arm64
2 participants