-
Notifications
You must be signed in to change notification settings - Fork 107
build: Add linux-arm64 build #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/extension_tests/deferred_bindings_tests/test_deferred_bindings.py
Outdated
Show resolved
Hide resolved
@@ -28,8 +47,7 @@ steps: | |||
condition: ne(variables['pythonVersion'], '3.7') | |||
- task: CopyFiles@2 | |||
inputs: | |||
contents: | | |||
${{ parameters.workerPath }} | |||
contents: '$(workerPath)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workerPath
is set above. For Python 3.12 & under, the path is python/prodV4/worker.py
. For 3.13+, it is python/proxyV4/worker.py
@@ -8,36 +8,28 @@ jobs: | |||
matrix: | |||
Python37V4: | |||
pythonVersion: '3.7' | |||
workerPath: 'python/prodV4/worker.py' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the comments from the 3.13 PR was to make workerPath
a top-level variable. Since workerPath
is different based on 3.13+ and <3.13, it can't be a global variable. The solution was to instead define 2 new global variables: one for the prodv4 path, and one for the proxyv4 path. Then, in the env_gen files, we determine which path to use based on the python version.
Description
Adds
linux-arm64
builds.Note:
win-arm64
is not supported because GRPC does not have awin-arm64
build.Testing fixes:
skipTest
variable settingPipeline refactoring:
pack/
intoeng/
workerPath
into top-level variablesBuild fixes:
OSX_ARM64
build intoOSX/ARM64
folderFixes #1643
PR information
Quality of Code and Contribution Guidelines