Enable debug logging add recommendation #948
Conversation
There was a problem hiding this comment.
nit changes requested.
You missed another comment from @gavin-aguiar - #943 (review). Could you please address that in here?
…-worker into wangbill/enable-debug-logging-add-recommendation
| @@ -459,6 +461,7 @@ async def _handle__function_environment_reload_request(self, req): | |||
| try: | |||
| logger.info('Received FunctionEnvironmentReloadRequest, ' | |||
| 'request ID: %s', self.request_id) | |||
| enable_debug_logging_recommendation() | |||
There was a problem hiding this comment.
@vrdmr Should we pass this along with the above 'Received FunctionEnvironmentReloadRequest' log, so we have only one grpc call here? Same with the worker init request
There was a problem hiding this comment.
During the init, it won't matter much as grpc overhead for only one call is very low. It is when that call is repeated multiple times, then it'll start hampering us.
Also, as this is something that we are expecting customers to observe and take action if necessary, I think we shouldn't mix it with the other logs.
I would recommend keeping as it is.
| from .logging import disable_console_logging, enable_console_logging | ||
| from .logging import enable_debug_logging_recommendation | ||
| from .logging import (logger, error_logger, is_system_log_category, | ||
| CONSOLE_LOG_PREFIX) |
There was a problem hiding this comment.
Why don't we merge these three imports into one?
YunchuWang
deleted the
wangbill/enable-debug-logging-add-recommendation
branch
YunchuWang
restored the
wangbill/enable-debug-logging-add-recommendation
branch
YunchuWang
deleted the
wangbill/enable-debug-logging-add-recommendation
branch
|
Child of #939 |
Description
Fixes #
PR information
Quality of Code and Contribution Guidelines