-
Notifications
You must be signed in to change notification settings - Fork 107
Enable debug logging add recommendation #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0f26f1d
d871a22
fad4b19
8521d47
a53fe76
f066ad8
ce1b3bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,20 +24,21 @@ | |
from . import functions | ||
from . import loader | ||
from . import protos | ||
from .bindings.shared_memory_data_transfer import SharedMemoryManager | ||
from .constants import (PYTHON_THREADPOOL_THREAD_COUNT, | ||
PYTHON_THREADPOOL_THREAD_COUNT_DEFAULT, | ||
PYTHON_THREADPOOL_THREAD_COUNT_MAX_37, | ||
PYTHON_THREADPOOL_THREAD_COUNT_MIN, | ||
PYTHON_ENABLE_DEBUG_LOGGING) | ||
from .extension import ExtensionManager | ||
from .logging import disable_console_logging, enable_console_logging | ||
from .logging import enable_debug_logging_recommendation | ||
from .logging import (logger, error_logger, is_system_log_category, | ||
CONSOLE_LOG_PREFIX) | ||
from .extension import ExtensionManager | ||
from .utils.common import get_app_setting, is_envvar_true | ||
from .utils.tracing import marshall_exception_trace | ||
from .utils.dependency import DependencyManager | ||
from .utils.tracing import marshall_exception_trace | ||
from .utils.wrappers import disable_feature_by | ||
from .bindings.shared_memory_data_transfer import SharedMemoryManager | ||
|
||
_TRUE = "true" | ||
|
||
|
@@ -262,6 +263,7 @@ async def _handle__worker_init_request(self, req): | |
logger.info('Received WorkerInitRequest, ' | ||
'python version %s, worker version %s, request ID %s', | ||
sys.version, __version__, self.request_id) | ||
enable_debug_logging_recommendation() | ||
|
||
worker_init_request = req.worker_init_request | ||
host_capabilities = worker_init_request.capabilities | ||
|
@@ -459,6 +461,7 @@ async def _handle__function_environment_reload_request(self, req): | |
try: | ||
logger.info('Received FunctionEnvironmentReloadRequest, ' | ||
'request ID: %s', self.request_id) | ||
enable_debug_logging_recommendation() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @vrdmr Should we pass this along with the above 'Received FunctionEnvironmentReloadRequest' log, so we have only one grpc call here? Same with the worker init request There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. During the init, it won't matter much as grpc overhead for only one call is very low. It is when that call is repeated multiple times, then it'll start hampering us. Also, as this is something that we are expecting customers to observe and take action if necessary, I think we shouldn't mix it with the other logs. I would recommend keeping as it is. |
||
|
||
func_env_reload_request = req.function_environment_reload_request | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we merge these three imports into one?