Skip to content

[Dynamic Instrumentation] DEBUG-3796 Fix rate limiting for probes that don't have limit #6921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

[Dynamic Instrumentation] DEBUG-3796 Fix rate limiting for probes that don't have limit #6921

merged 3 commits into from
May 14, 2025

Conversation

dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented May 2, 2025 •
edited
Loading

Summary of changes

Fix issue that cause span decoration probes to not proceed due a sampler.

Implementation details

Span decoration probes (also metric probe) should not use the default rate limit. Currently, we don't add any limit when creating the probe, but during the processing of the probe, we are trying the get the probe metadata for that specific probe instance and when we can't find sampling, we are creatin gone with default limit. This PR fix that by providing a not limit sampler for those probes.

@dudikeleti dudikeleti requested a review from a team as a code owner May 2, 2025 08:36
@dudikeleti dudikeleti requested a review from GreenMatan May 2, 2025 08:36
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels May 2, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 2, 2025 •
edited
Loading

Datadog Report

All test runs 2b34914 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 1 0 0 258231 3374 30h 52m 11.16s Link
exploration_tests 0 0 0 7433 0 10m 14.76s Link

❌ Failed Tests (1)

  • TestSecurityInitialization - Datadog.Trace.Security.IntegrationTests.AspNetCore5AsmInitializationSecurityEnabledWithBadRuleset - Details

    Expand for error 
     Results do not match.
 Differences:
 Received: Security.AspNetCore5AsmInitializationSecurityEnabledWithBadRuleset.TestSecurityInitialization.received.txt
 Verified: Security.AspNetCore5AsmInitializationSecurityEnabledWithBadRuleset.TestSecurityInitialization.verified.txt
 Compare Result:
   [
     {
       TraceId: Id_1,
       SpanId: Id_2,
       Name: aspnet_core.request,
 ...

@andrewlock
Copy link
Member

andrewlock commented May 2, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6921) - mean (68ms)  : 64, 73
     .   : milestone, 68,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6921) - mean (1,005ms)  : 975, 1036
     .   : milestone, 1005,
    master - mean (1,000ms)  : 980, 1020
     .   : milestone, 1000,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6921) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6921) - mean (698ms)  : 683, 714
     .   : milestone, 698,
    master - mean (695ms)  : 672, 717
     .   : milestone, 695,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6921) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6921) - mean (654ms)  : 635, 674
     .   : milestone, 654,
    master - mean (651ms)  : 633, 668
     .   : milestone, 651,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6921) - mean (189ms)  : 185, 193
     .   : milestone, 189,
    master - mean (190ms)  : 185, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6921) - mean (1,109ms)  : 1078, 1140
     .   : milestone, 1109,
    master - mean (1,107ms)  : 1084, 1130
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6921) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (268ms)  : 262, 274
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6921) - mean (878ms)  : 853, 903
     .   : milestone, 878,
    master - mean (879ms)  : 844, 913
     .   : milestone, 879,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6921) - mean (261ms)  : 255, 266
     .   : milestone, 261,
    master - mean (260ms)  : 256, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (6921) - mean (866ms)  : 839, 893
     .   : milestone, 866,
    master - mean (869ms)  : 836, 902
     .   : milestone, 869,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6921 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.169
  • 2 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.8 KB 5.72 KB -75 B -1.29%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.25μs 144ns 1.44μs 0 0 0 5.6 KB
master StartStopWithChild netcoreapp3.1 9.83μs 99.8ns 988ns 0 0 0 5.8 KB
master StartStopWithChild net472 15.2μs 72.2ns 289ns 1.03 0.344 0.0688 6.15 KB
#6921 StartStopWithChild net6.0 7.68μs 103ns 1.03μs 0 0 0 5.58 KB
#6921 StartStopWithChild netcoreapp3.1 9.66μs 138ns 1.38μs 0 0 0 5.72 KB
#6921 StartStopWithChild net472 15μs 77.8ns 397ns 0.991 0.305 0.0762 6.14 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.35 KB 3.31 KB -34 B -1.02%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 498μs 1.08μs 4.18μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 1.29μs 4.98μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 860μs 2.13μs 8.25μs 0 0 0 3.35 KB
#6921 WriteAndFlushEnrichedTraces net6.0 511μs 510ns 1.84μs 0 0 0 2.7 KB
#6921 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.77μs 6.37μs 0 0 0 2.7 KB
#6921 WriteAndFlushEnrichedTraces net472 871μs 808ns 3.13μs 0 0 0 3.31 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 716ns 4.47μs 0 0 0 14.48 KB
master SendRequest netcoreapp3.1 142μs 811ns 6.07μs 0 0 0 17.28 KB
master SendRequest net472 0.0024ns 0.00101ns 0.00376ns 0 0 0 0 b
#6921 SendRequest net6.0 129μs 269ns 1.04μs 0 0 0 14.48 KB
#6921 SendRequest netcoreapp3.1 151μs 428ns 2.01μs 0 0 0 17.28 KB
#6921 SendRequest net472 0.00233ns 0.000817ns 0.00306ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 612μs 6.19μs 60μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 724μs 6.28μs 60.9μs 0 0 0 41.78 KB
master WriteAndFlushEnrichedTraces net472 857μs 5.02μs 49.9μs 7.81 0 0 53.47 KB
#6921 WriteAndFlushEnrichedTraces net6.0 605μs 5.62μs 55.4μs 0 0 0 41.6 KB
#6921 WriteAndFlushEnrichedTraces netcoreapp3.1 724μs 7.31μs 72μs 0 0 0 41.83 KB
#6921 WriteAndFlushEnrichedTraces net472 886μs 5.09μs 38.4μs 4.46 0 0 53.45 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 1.02ns 3.82ns 0.013 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 1.9μs 4.54ns 17ns 0.00912 0 0 1.02 KB
master ExecuteNonQuery net472 2.08μs 3.4ns 12.7ns 0.154 0.0103 0 995 B
#6921 ExecuteNonQuery net6.0 1.37μs 3.05ns 11.4ns 0.0136 0 0 1.03 KB
#6921 ExecuteNonQuery netcoreapp3.1 1.8μs 5.51ns 19.9ns 0.00903 0 0 1.02 KB
#6921 ExecuteNonQuery net472 2.1μs 4.1ns 15.9ns 0.157 0.0105 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 0.581ns 2.1ns 0.0118 0 0 984 B
master CallElasticsearch netcoreapp3.1 1.52μs 1.08ns 4.19ns 0.00748 0 0 984 B
master CallElasticsearch net472 2.57μs 1.78ns 6.65ns 0.157 0 0 1 KB
master CallElasticsearchAsync net6.0 1.31μs 1.5ns 5.79ns 0.0131 0 0 960 B
master CallElasticsearchAsync netcoreapp3.1 1.62μs 1.29ns 4.99ns 0.00811 0 0 1.03 KB
master CallElasticsearchAsync net472 2.7μs 0.977ns 3.52ns 0.162 0 0 1.06 KB
#6921 CallElasticsearch net6.0 1.21μs 4.74ns 21.2ns 0.012 0 0 984 B
#6921 CallElasticsearch netcoreapp3.1 1.54μs 4.17ns 16.2ns 0.00772 0 0 984 B
#6921 CallElasticsearch net472 2.52μs 1.16ns 4.34ns 0.152 0 0 1 KB
#6921 CallElasticsearchAsync net6.0 1.26μs 1.04ns 3.74ns 0.0125 0 0 960 B
#6921 CallElasticsearchAsync netcoreapp3.1 1.75μs 2.52ns 9.1ns 0.00871 0 0 1.03 KB
#6921 CallElasticsearchAsync net472 2.77μs 1.51ns 5.63ns 0.166 0 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.28μs 0.574ns 2.15ns 0.0129 0 0 960 B
master ExecuteAsync netcoreapp3.1 1.7μs 2.25ns 8.41ns 0.00848 0 0 960 B
master ExecuteAsync net472 1.93μs 0.866ns 3.36ns 0.144 0 0 923 B
#6921 ExecuteAsync net6.0 1.23μs 0.591ns 2.21ns 0.0124 0 0 960 B
#6921 ExecuteAsync netcoreapp3.1 1.67μs 3.94ns 15.3ns 0.00823 0 0 960 B
#6921 ExecuteAsync net472 1.79μs 0.919ns 3.44ns 0.143 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.59μs 2.41ns 9.34ns 0.0228 0 0 2.32 KB
master SendAsync netcoreapp3.1 5.27μs 3.52ns 13.6ns 0.0262 0 0 2.86 KB
master SendAsync net472 7.49μs 5.18ns 18.7ns 0.485 0 0 3.13 KB
#6921 SendAsync net6.0 4.29μs 4.13ns 15.5ns 0.0216 0 0 2.32 KB
#6921 SendAsync netcoreapp3.1 5.53μs 6ns 23.2ns 0.0276 0 0 2.86 KB
#6921 SendAsync net472 7.43μs 3.64ns 13.6ns 0.482 0 0 3.13 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 4.09ns 14.7ns 0.0235 0 0 1.71 KB
master EnrichedLog netcoreapp3.1 2.4μs 3.92ns 14.7ns 0.0119 0 0 1.71 KB
master EnrichedLog net472 2.75μs 5.93ns 23ns 0.259 0 0 1.64 KB
#6921 EnrichedLog net6.0 1.56μs 0.789ns 2.85ns 0.0236 0 0 1.71 KB
#6921 EnrichedLog netcoreapp3.1 2.23μs 2.14ns 8.28ns 0.0222 0 0 1.71 KB
#6921 EnrichedLog net472 2.61μs 1.22ns 4.55ns 0.26 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 328ns 1.27μs 0 0 0 4.32 KB
master EnrichedLog netcoreapp3.1 126μs 469ns 1.76μs 0 0 0 4.32 KB
master EnrichedLog net472 159μs 683ns 2.64μs 0 0 0 4.51 KB
#6921 EnrichedLog net6.0 111μs 201ns 780ns 0 0 0 4.32 KB
#6921 EnrichedLog netcoreapp3.1 117μs 169ns 632ns 0 0 0 4.32 KB
#6921 EnrichedLog net472 149μs 174ns 649ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.14μs 2.67ns 10.4ns 0.0313 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 4.15μs 3.64ns 14.1ns 0.0206 0 0 2.26 KB
master EnrichedLog net472 4.82μs 3.13ns 11.7ns 0.314 0 0 2.09 KB
#6921 EnrichedLog net6.0 3.13μs 2.09ns 8.11ns 0.0158 0 0 2.26 KB
#6921 EnrichedLog netcoreapp3.1 4.16μs 3.25ns 12.6ns 0.0208 0 0 2.26 KB
#6921 EnrichedLog net472 4.92μs 2.79ns 10.5ns 0.32 0 0 2.09 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.45μs 2.72ns 10.5ns 0.0143 0 0 1.15 KB
master SendReceive netcoreapp3.1 1.78μs 8.33ns 34.4ns 0.00898 0 0 1.15 KB
master SendReceive net472 2.19μs 9.79ns 37.9ns 0.184 0 0 1.16 KB
#6921 SendReceive net6.0 1.32μs 0.906ns 3.39ns 0.0133 0 0 1.15 KB
#6921 SendReceive netcoreapp3.1 1.86μs 2.41ns 9.35ns 0.00926 0 0 1.15 KB
#6921 SendReceive net472 2.07μs 0.993ns 3.71ns 0.175 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.66μs 2.35ns 9.1ns 0.0133 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 4.17μs 3.5ns 12.1ns 0.0209 0 0 1.69 KB
master EnrichedLog net472 4.55μs 3.8ns 14.2ns 0.32 0 0 2.08 KB
#6921 EnrichedLog net6.0 2.77μs 1.43ns 5.55ns 0.0138 0 0 1.64 KB
#6921 EnrichedLog netcoreapp3.1 4.05μs 5.32ns 19.9ns 0.0202 0 0 1.69 KB
#6921 EnrichedLog net472 4.52μs 2.99ns 10.8ns 0.315 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6921

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.175 682.99 581.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 410ns 0.277ns 1.04ns 0.00812 0 0 584 B
master StartFinishSpan netcoreapp3.1 634ns 0.659ns 2.55ns 0.00635 0 0 584 B
master StartFinishSpan net472 683ns 0.185ns 0.692ns 0.0927 0 0 586 B
master StartFinishScope net6.0 480ns 0.522ns 2.02ns 0.00974 0 0 704 B
master StartFinishScope netcoreapp3.1 774ns 0.796ns 2.87ns 0.00751 0 0 704 B
master StartFinishScope net472 789ns 0.567ns 2.2ns 0.103 0 0 666 B
#6921 StartFinishSpan net6.0 395ns 0.315ns 1.22ns 0.0082 0 0 584 B
#6921 StartFinishSpan netcoreapp3.1 570ns 0.364ns 1.41ns 0.0057 0 0 584 B
#6921 StartFinishSpan net472 581ns 0.501ns 1.94ns 0.0928 0 0 586 B
#6921 StartFinishScope net6.0 509ns 1.29ns 4.82ns 0.01 0 0 704 B
#6921 StartFinishScope netcoreapp3.1 766ns 0.583ns 2.26ns 0.00756 0 0 704 B
#6921 StartFinishScope net472 821ns 0.494ns 1.91ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6921

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.180 716.58 607.31
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.153 980.74 850.76

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 717ns 0.25ns 0.937ns 0.00757 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 996ns 5.57ns 37.8ns 0.00492 0 0 704 B
master RunOnMethodBegin net472 1.12μs 0.755ns 2.83ns 0.101 0 0 666 B
#6921 RunOnMethodBegin net6.0 608ns 0.501ns 1.94ns 0.00903 0 0 704 B
#6921 RunOnMethodBegin netcoreapp3.1 851ns 0.265ns 0.919ns 0.00863 0 0 704 B
#6921 RunOnMethodBegin net472 1.16μs 0.879ns 3.29ns 0.105 0 0 666 B

GreenMatan
GreenMatan approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@GreenMatan GreenMatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. I would consider adding a test to make sure these improvements won't break in the future.

@dudikeleti dudikeleti force-pushed the dudik/fix-span-decoration-has-condition branch from 4bacb39 to 2b34914 Compare May 8, 2025 08:29
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6921 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.282
  • 1 benchmarks are slower, with geometric mean 1.259
  • 5 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.76 KB 5.73 KB -33 B -0.57%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.7μs 57.6ns 305ns 0 0 0 5.53 KB
master StartStopWithChild netcoreapp3.1 13.7μs 69ns 301ns 0 0 0 5.76 KB
master StartStopWithChild net472 21.8μs 125ns 1μs 0.983 0.328 0.109 6.12 KB
#6921 StartStopWithChild net6.0 10.5μs 56.3ns 298ns 0 0 0 5.55 KB
#6921 StartStopWithChild netcoreapp3.1 13.8μs 51.8ns 201ns 0 0 0 5.73 KB
#6921 StartStopWithChild net472 22.2μs 123ns 755ns 0.98 0.327 0.109 6.13 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.35 KB 3.31 KB -46 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 943μs 50.7ns 196ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.07ms 228ns 882ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.24ms 544ns 2.11μs 0 0 0 3.35 KB
#6921 WriteAndFlushEnrichedTraces net6.0 960μs 93.3ns 323ns 0 0 0 2.71 KB
#6921 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 147ns 530ns 0 0 0 2.7 KB
#6921 WriteAndFlushEnrichedTraces net472 1.22ms 1.16μs 4.33μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 329μs 1.61μs 6.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 493μs 1.45μs 5.63μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 83.6ns 313ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 339μs 1.4μs 5.42μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 477μs 2.05μs 7.94μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 448μs 281ns 1.09μs 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.71ns 10.1ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 397ns 2.01ns 9.44ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 301ns 0.0308ns 0.111ns 0.0441 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.3μs 30.4ns 118ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.62μs 38.6ns 168ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.72μs 2ns 7.75ns 0.57 0 0 3.8 KB
#6921 AllCycleSimpleBody net6.0 334μs 396ns 1.53μs 0 0 0 197.06 KB
#6921 AllCycleSimpleBody netcoreapp3.1 482μs 2.14μs 8.3μs 0 0 0 204.77 KB
#6921 AllCycleSimpleBody net472 460μs 158ns 613ns 35.7 2.23 0 236.37 KB
#6921 AllCycleMoreComplexBody net6.0 335μs 1.61μs 6.82μs 0 0 0 200.56 KB
#6921 AllCycleMoreComplexBody netcoreapp3.1 508μs 2.07μs 8μs 0 0 0 208.18 KB
#6921 AllCycleMoreComplexBody net472 468μs 76.1ns 285ns 37 0 0 239.87 KB
#6921 ObjectExtractorSimpleBody net6.0 316ns 0.0931ns 0.361ns 0 0 0 280 B
#6921 ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.01ns 8.54ns 0 0 0 272 B
#6921 ObjectExtractorSimpleBody net472 302ns 0.0148ns 0.0553ns 0.044 0 0 281 B
#6921 ObjectExtractorMoreComplexBody net6.0 6.43μs 31.1ns 120ns 0 0 0 3.78 KB
#6921 ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 9.14ns 35.4ns 0 0 0 3.69 KB
#6921 ObjectExtractorMoreComplexBody net472 6.81μs 13.1ns 50.6ns 0.602 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6921 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6921 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6921 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6921 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6921 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6921 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#6921 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6921 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6921 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#6921 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6921 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6921 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.7μs 45.7ns 158ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 71.7μs 34.9ns 131ns 0 0 0 17.42 KB
master SendRequest net472 0.026ns 0.002ns 0.00775ns 0 0 0 0 b
#6921 SendRequest net6.0 59.9μs 42.2ns 152ns 0 0 0 14.53 KB
#6921 SendRequest netcoreapp3.1 71.4μs 270ns 1.48μs 0 0 0 17.42 KB
#6921 SendRequest net472 0.0175ns 0.00153ns 0.00593ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #6921

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.259 636,836.33 802,019.58

More allocations ⚠️ in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.87 KB 43.02 KB 1.15 KB 2.75%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 636μs 868ns 3.36μs 0 0 0 41.72 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.73μs 23.3μs 0 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 889μs 4.46μs 19.5μs 8.33 0 0 56.53 KB
#6921 WriteAndFlushEnrichedTraces net6.0 801μs 682ns 2.64μs 0 0 0 41.61 KB
#6921 WriteAndFlushEnrichedTraces netcoreapp3.1 721μs 911ns 3.41μs 0 0 0 43.02 KB
#6921 WriteAndFlushEnrichedTraces net472 881μs 4.43μs 20.8μs 8.33 0 0 56.56 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.95μs 7.3ns 28.3ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.46μs 8.67ns 33.6ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.9μs 3.09ns 12ns 0.158 0.0143 0 995 B
#6921 ExecuteNonQuery net6.0 1.96μs 3.26ns 12.6ns 0 0 0 1.03 KB
#6921 ExecuteNonQuery netcoreapp3.1 2.43μs 11.1ns 44.2ns 0 0 0 1.02 KB
#6921 ExecuteNonQuery net472 2.72μs 2.85ns 11ns 0.15 0.0137 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.75μs 8.81ns 34.1ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.25μs 11.2ns 48.9ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.45μs 4.1ns 15.9ns 0.157 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.82μs 7.68ns 28.7ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.43μs 11.1ns 44.5ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.75μs 3.03ns 11.7ns 0.168 0 0 1.11 KB
#6921 CallElasticsearch net6.0 1.71μs 9.26ns 49ns 0 0 0 1.04 KB
#6921 CallElasticsearch netcoreapp3.1 2.35μs 10.5ns 40.7ns 0 0 0 1.04 KB
#6921 CallElasticsearch net472 3.45μs 3.06ns 11.9ns 0.155 0 0 1.05 KB
#6921 CallElasticsearchAsync net6.0 1.86μs 2.39ns 8.96ns 0 0 0 1.02 KB
#6921 CallElasticsearchAsync netcoreapp3.1 2.33μs 12.1ns 61.8ns 0 0 0 1.09 KB
#6921 CallElasticsearchAsync net472 3.64μs 2.2ns 8.5ns 0.163 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.81μs 2.09ns 8.1ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.28μs 1.73ns 6ns 0 0 0 960 B
master ExecuteAsync net472 2.68μs 5.65ns 21.9ns 0.147 0 0 923 B
#6921 ExecuteAsync net6.0 1.88μs 1.09ns 4.09ns 0 0 0 960 B
#6921 ExecuteAsync netcoreapp3.1 2.27μs 3.5ns 12.6ns 0 0 0 960 B
#6921 ExecuteAsync net472 2.57μs 3.42ns 13.2ns 0.141 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.08μs 19.9ns 77.2ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.6μs 9.04ns 35ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 9.97ns 38.6ns 0.491 0 0 3.19 KB
#6921 SendAsync net6.0 6.88μs 21.1ns 76.1ns 0 0 0 2.37 KB
#6921 SendAsync netcoreapp3.1 8.4μs 24.7ns 92.4ns 0 0 0 2.9 KB
#6921 SendAsync net472 12.3μs 9.52ns 36.9ns 0.488 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6921

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.282 482,650.00 376,400.00 several?

More allocations ⚠️ in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 44.25 KB 1.61 KB 3.77%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.82 KB 44.14 KB 320 B 0.73%

Fewer allocations 🎉 in #6921

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 260.98 KB 258.83 KB -2.15 KB -0.82%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.12 KB 256.34 KB -17.78 KB -6.48%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 41.9μs 223ns 1.2μs 0 0 0 43.82 KB
master StringConcatBenchmark netcoreapp3.1 49.7μs 290ns 2.34μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.9μs 154ns 555ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 482μs 906ns 3.14μs 0 0 0 260.98 KB
master StringConcatAspectBenchmark netcoreapp3.1 505μs 2.28μs 8.53μs 0 0 0 274.12 KB
master StringConcatAspectBenchmark net472 409μs 1.37μs 4.95μs 0 0 0 286.72 KB
#6921 StringConcatBenchmark net6.0 44.1μs 255ns 1.82μs 0 0 0 44.14 KB
#6921 StringConcatBenchmark netcoreapp3.1 50.8μs 485ns 4.71μs 0 0 0 44.25 KB
#6921 StringConcatBenchmark net472 56.5μs 172ns 644ns 0 0 0 57.34 KB
#6921 StringConcatAspectBenchmark net6.0 408μs 5.43μs 53.2μs 0 0 0 258.83 KB
#6921 StringConcatAspectBenchmark netcoreapp3.1 513μs 2.05μs 7.94μs 0 0 0 256.34 KB
#6921 StringConcatAspectBenchmark net472 401μs 1.89μs 7.07μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 7.54ns 29.2ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.5μs 7.98ns 30.9ns 0 0 0 1.76 KB
master EnrichedLog net472 3.91μs 2.47ns 9.58ns 0.254 0 0 1.69 KB
#6921 EnrichedLog net6.0 2.59μs 13.1ns 57.3ns 0 0 0 1.76 KB
#6921 EnrichedLog netcoreapp3.1 3.42μs 14ns 54.1ns 0 0 0 1.76 KB
#6921 EnrichedLog net472 3.91μs 3.53ns 13.2ns 0.253 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 106ns 412ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 128μs 54.6ns 197ns 0 0 0 4.37 KB
master EnrichedLog net472 166μs 112ns 434ns 0 0 0 4.57 KB
#6921 EnrichedLog net6.0 124μs 59.5ns 215ns 0 0 0 4.37 KB
#6921 EnrichedLog netcoreapp3.1 127μs 55.3ns 192ns 0 0 0 4.37 KB
#6921 EnrichedLog net472 168μs 25.4ns 98.5ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.99μs 6.45ns 25ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.87μs 19.5ns 75.6ns 0 0 0 2.32 KB
master EnrichedLog net472 7.36μs 10.4ns 40.5ns 0.327 0 0 2.14 KB
#6921 EnrichedLog net6.0 5.24μs 19.2ns 74.5ns 0 0 0 2.32 KB
#6921 EnrichedLog netcoreapp3.1 6.59μs 24.4ns 94.6ns 0 0 0 2.32 KB
#6921 EnrichedLog net472 7.32μs 11.7ns 45.5ns 0.331 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2μs 9.17ns 36.7ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.57μs 10.1ns 39.2ns 0 0 0 1.21 KB
master SendReceive net472 3.03μs 3.28ns 12.7ns 0.18 0 0 1.21 KB
#6921 SendReceive net6.0 2.02μs 10.7ns 38.7ns 0 0 0 1.21 KB
#6921 SendReceive netcoreapp3.1 2.57μs 3.19ns 12.3ns 0 0 0 1.21 KB
#6921 SendReceive net472 3.05μs 6.07ns 23.5ns 0.182 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.23μs 8.89ns 33.2ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.55μs 20.7ns 80ns 0 0 0 1.69 KB
master EnrichedLog net472 6.52μs 5.26ns 19.7ns 0.325 0 0 2.08 KB
#6921 EnrichedLog net6.0 4.16μs 3.62ns 12.6ns 0 0 0 1.64 KB
#6921 EnrichedLog netcoreapp3.1 5.62μs 11.5ns 44.3ns 0 0 0 1.69 KB
#6921 EnrichedLog net472 6.73μs 5.92ns 22.9ns 0.301 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 752ns 4.07ns 21.1ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 938ns 4.37ns 16.9ns 0 0 0 584 B
master StartFinishSpan net472 911ns 0.311ns 1.2ns 0.0923 0 0 586 B
master StartFinishScope net6.0 898ns 4.19ns 16.2ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.18μs 5.49ns 21.3ns 0 0 0 704 B
master StartFinishScope net472 1.13μs 0.236ns 0.915ns 0.102 0 0 666 B
#6921 StartFinishSpan net6.0 741ns 4.16ns 27ns 0 0 0 584 B
#6921 StartFinishSpan netcoreapp3.1 935ns 4.75ns 23.3ns 0 0 0 584 B
#6921 StartFinishSpan net472 938ns 0.819ns 3.17ns 0.0888 0 0 586 B
#6921 StartFinishScope net6.0 903ns 3.95ns 15.3ns 0 0 0 704 B
#6921 StartFinishScope netcoreapp3.1 1.11μs 5.44ns 23.1ns 0 0 0 704 B
#6921 StartFinishScope net472 1.13μs 0.147ns 0.571ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.04μs 0.517ns 2ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.35μs 6.15ns 23.8ns 0 0 0 704 B
master RunOnMethodBegin net472 1.35μs 0.798ns 2.99ns 0.102 0 0 666 B
#6921 RunOnMethodBegin net6.0 1.02μs 3.8ns 14.7ns 0 0 0 704 B
#6921 RunOnMethodBegin netcoreapp3.1 1.45μs 6ns 23.2ns 0 0 0 704 B
#6921 RunOnMethodBegin net472 1.39μs 4.11ns 15.9ns 0.103 0 0 666 B

@dudikeleti dudikeleti force-pushed the dudik/fix-span-decoration-has-condition branch from 2b34914 to c002527 Compare May 13, 2025 10:46
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 13, 2025 •
edited
Loading

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

Branch report: dudik/fix-span-decoration-has-condition
Commit report: c002527
Test service: dd-trace-dotnet

✅ 0 Failed, 35 Passed, 0 Skipped, 16m 7.76s Total Time

Was this helpful? Give us feedback!

@dudikeleti dudikeleti merged commit 24ee948 into master May 14, 2025
132 checks passed
@dudikeleti dudikeleti deleted the dudik/fix-span-decoration-has-condition branch May 14, 2025 12:41
@github-actions github-actions bot added this to the vNext-v3 milestone May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenMatan GreenMatan GreenMatan approved these changes

Assignees
No one assigned
Labels
area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dudikeleti @andrewlock @GreenMatan