Skip to content

[AAP] Update waf version to v1.25.1 #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

daniel-romano-DD
Copy link
Contributor

Summary of changes

Update waf version to v1.25.1

Reason for change

Implementation details

Test coverage

Other details

Copy link
Contributor

github-actions bot commented Jun 9, 2025

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

3 occurrences of :

-        "_dd.appsec.waf.version": "1.25.0",
+        "_dd.appsec.waf.version": "1.25.1",

8 occurrences of :

-      _dd.appsec.waf.version: 1.25.0,
+      _dd.appsec.waf.version: 1.25.1,

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 9, 2025

Datadog Report

Branch report: dani/asm/waf_v1.25_1
Commit report: 8d8e9ba
Test service: dd-trace-dotnet

✅ 0 Failed, 249990 Passed, 2471 Skipped, 18h 40m 1.86s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

  • TestSessionTimeoutVulnerability - Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsRestartedSampleIastEnabled - Last Failure

    Expand for error
     Results do not match.
     Differences:
     Received: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.received.txt
     Verified: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.verified.txt
     Compare Result:
       [
         {
           TraceId: Id_1,
           SpanId: Id_2,
           Name: session_timeout,
     ...
    
  • SubmitsTraces - Datadog.Trace.Security.IntegrationTests.Iast.DeduplicationTests - Last Failure

    Expand for error
     Results do not match.
     Differences:
     Received: iast.deduplication.deduplicated.All.received.txt
     Verified: iast.deduplication.deduplicated.All.verified.txt
     Compare Result:
       [
         {
           TraceId: Id_1,
           SpanId: Id_2,
           Name: weak_hashing,
     ...
    

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7079) - mean (68ms)  : 65, 72
     .   : milestone, 68,
    master - mean (69ms)  : 63, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7079) - mean (1,020ms)  : 1000, 1040
     .   : milestone, 1020,
    master - mean (1,015ms)  : 1001, 1029
     .   : milestone, 1015,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7079) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7079) - mean (698ms)  : 685, 711
     .   : milestone, 698,
    master - mean (699ms)  : 690, 708
     .   : milestone, 699,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7079) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7079) - mean (672ms)  : 657, 687
     .   : milestone, 672,
    master - mean (673ms)  : 655, 691
     .   : milestone, 673,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7079) - mean (191ms)  : 185, 197
     .   : milestone, 191,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (7079) - mean (1,165ms)  : 1146, 1184
     .   : milestone, 1165,
    master - mean (1,168ms)  : 1151, 1186
     .   : milestone, 1168,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7079) - mean (270ms)  : 267, 274
     .   : milestone, 270,
    master - mean (276ms)  : 252, 300
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7079) - mean (933ms)  : 916, 950
     .   : milestone, 933,
    master - mean (938ms)  : 923, 953
     .   : milestone, 938,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7079) - mean (263ms)  : 260, 266
     .   : milestone, 263,
    master - mean (265ms)  : 262, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (7079) - mean (929ms)  : 916, 942
     .   : milestone, 929,
    master - mean (930ms)  : 913, 948
     .   : milestone, 930,

Loading

@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review June 10, 2025 17:59
@daniel-romano-DD daniel-romano-DD requested review from a team as code owners June 10, 2025 17:59
Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daniel-romano-DD daniel-romano-DD merged commit 37b3b03 into master Jun 11, 2025
66 of 69 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/waf_v1.25_1 branch June 11, 2025 14:16
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants