Skip to content

Add a complexity limit on displaying layer thumbnails to improve performance #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2025
Merged

Add a complexity limit on displaying layer thumbnails to improve performance #2828

merged 5 commits into from
Jul 10, 2025

Conversation

0HyperCube
Copy link
Member

  • Each graphic element gets a render complexity
  • Layers with high render complexity get skipped for thumbnails

TrueDoctor
TrueDoctor reviewed Jul 6, 2025
View reviewed changes
TrueDoctor
TrueDoctor approved these changes Jul 6, 2025
View reviewed changes
Copy link
Member

@TrueDoctor TrueDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, we might want to special case textures as mentioned in the comment but this looks fine either way

@Keavon Keavon force-pushed the master branch 4 times, most recently from ec51271 to e025103 Compare July 10, 2025 05:48
@Keavon Keavon changed the title Skip complex layer thumbnails Add a complexity limit on displaying layer thumbnails for performance Jul 10, 2025
@Keavon Keavon changed the title Add a complexity limit on displaying layer thumbnails for performance Add a complexity limit on displaying layer thumbnails to improve performance Jul 10, 2025
@Keavon Keavon enabled auto-merge (squash) July 10, 2025 07:44
@Keavon Keavon merged commit 13ad814 into master Jul 10, 2025
4 checks passed
@Keavon Keavon deleted the skip-complex-thumbnails branch July 10, 2025 07:57
urisinger pushed a commit to urisinger/Graphite that referenced this pull request Jul 15, 2025
@0HyperCube @Keavon @urisinger
Add a complexity limit on displaying layer thumbnails to improve perf…
4460f51 
…ormance (GraphiteEditor#2828)

* Skip complex layer thumbnails

* Set Raster<GPU> to have usize::MAX render complexity

* Code review

---------

Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

@TrueDoctor TrueDoctor TrueDoctor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0HyperCube @Keavon @TrueDoctor