Backport pr-919 to gold/2021 #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scikit-build 0.14.0 -DCMAKE_FIND_PATH_MODE_INCLUDE=ONLY started being set. This breaks working of IntelDPCPP integration with cmake, since find_file starts ignoring specified paths and hints. Setting the value in CMakeLists.txt overrides that value
Variables were set in the nested scope and not propagated to the parent scope. The config also has erroneous space before the trailing @ symbol.
This is to ensure that find_library can find libpi_level_zero and libpi_opencl
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/930/index.html |
|
@xaleryb The internal CI is green, merging. FYI, some other changes in gold/2021 conflict with main branch. Resolving the conflict is easy though. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backport changes to CMakeLists.txt added in #919 to fix building of gold/2021 sources with updated scikit-build.