Skip to content

chore: use shorthand of sherif consistently #6686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

manudeli
Copy link
Collaborator

We can check shorthands for sherif
I updated script test:sherif's rules consistently

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 0:12am

@manudeli manudeli marked this pull request as ready for review January 11, 2024 18:20
@manudeli manudeli marked this pull request as draft January 11, 2024 18:20
Copy link

nx-cloud bot commented Jan 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4232d83. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Jan 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4232d83:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a127bf) 41.71% compared to head (4232d83) 41.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6686   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files         179      179           
  Lines        7007     7007           
  Branches     1416     1416           
=======================================
  Hits         2923     2923           
  Misses       3713     3713           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manudeli manudeli marked this pull request as ready for review January 11, 2024 18:25
@TkDodo
Copy link
Collaborator

TkDodo commented Jan 13, 2024

i think the shorthand is not really readable. -p for IGNORING a package :/

--ignore-package was added as workaround for QuiiBz/sherif#41, which is now closed.

So I think updating sherif and removing the workaround might be better if you want to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants