[AIE2P] Fix broadcast intrinsics. #503
Conversation
SagarMaheshwari99
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto and
stephenneuendorffer
as code owners
SagarMaheshwari99
force-pushed
the
sagarm.bcst.intrs
branch
from
824913c to
526ab7c
Compare
| @@ -1354,10 +1354,10 @@ INTRINSIC(void *) extract_address(v16int32 v, int idx) { | |||
| } | |||
| // broadcast from scalar (alternative syntax to broadcast to vector) | |||
| INTRINSIC(v64int8) | |||
| broadcast_s8(char b) { return b - v64int8{0}; } | |||
| broadcast_s8(int b) { return (char)b - v64int8{0}; } | |||
There was a problem hiding this comment.
Can we update the tests as well?
There was a problem hiding this comment.
As I remember, we reused aie2 tests for aie2p as well. Since at it, can you please fix it for aie2 as well.
| @@ -1354,10 +1354,10 @@ INTRINSIC(void *) extract_address(v16int32 v, int idx) { | |||
| } | |||
| // broadcast from scalar (alternative syntax to broadcast to vector) | |||
| INTRINSIC(v64int8) | |||
| broadcast_s8(char b) { return b - v64int8{0}; } | |||
| broadcast_s8(int b) { return (char)b - v64int8{0}; } | |||
There was a problem hiding this comment.
v64int8{b} doesn't work?
There was a problem hiding this comment.
No, that will only initialize the first element of the vector with b.
But the subtraction (char)b - v64int8{0} is performed element-wise due to how vector types work, effectively resulting in a vector where each element is b.
We don't even need to specify 0 when initializing a v64int8 vector, since all elements of a vector are initialized to 0 by default.
So (char)b - v64int8{} will also work.
|
|
||
| INTRINSIC(v32int16) | ||
| broadcast_s16(short b) { return b - v32int16{0}; } | ||
| broadcast_s16(int b) { return (short)b - v32int16{0}; } |
There was a problem hiding this comment.
why weren't we happy with implicit casting?
There was a problem hiding this comment.
short b is promoted to int
No description provided.