Skip to content

Add proofs for Ring and commutative semigroup #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 19, 2022

Conversation

Akshobhya1234
Copy link
Contributor

@Akshobhya1234 Akshobhya1234 commented Oct 30, 2022

In this PR add the folllowing proofs for Ring

  • If x + x = x then x = 0
  • x * (y - z) = x * y - x * z
  • (y - z) * x = (y * x) - (z * x)

For commutative semigroup

  • semimedial : Semimedial _∙_

@jamesmckinna
Copy link
Contributor

I'm increasingly unsure about the value of the first lemma: is this not a simple consequence of cancellability, once it has been generalised to

  • if x + y = y then x = 0?

The other two seem more useful, however.

@Akshobhya1234
Copy link
Contributor Author

I'm increasingly unsure about the value of the first lemma: is this not a simple consequence of cancellability, once it has been generalised to

  • if x + y = y then x = 0?

The other two seem more useful, however.

Hmm not sure. Isn't it x + y = x + z then y = z?. In this case y and z = 0 or y=x=z? The proof is If x+x=x then x = 0. I agree that we should not have duplicate proofs with different names.

@Akshobhya1234 Akshobhya1234 changed the title Add proofs for Ring Add proofs for Ring and commutative semigroup Nov 5, 2022
@jamesmckinna
Copy link
Contributor

Sorry I haven't got back to you... overwhelmed by other stuff.
I guess my point was, right-+-cancellation from x + y ≈ z + y would yield x ≈ z... and that x + y ≈ y, by left-identity, is equivalent to x + y ≈ z + y for z = 0#. And then your lemma follows by making the further identification y = x. So in that sense, it is 'just' (reducible to) a combination of cancellability and left-identity, and hence, maybe, not such an 'interesting' lemma? And if it is interesting enough to add to the library, then the generalisation to x + y ≈ y ⇒ x ≈ 0#, is surely the more 'useful' statement?

@Akshobhya1234
Copy link
Contributor Author

Sorry I haven't got back to you... overwhelmed by other stuff. I guess my point was, right-+-cancellation from x + y ≈ z + y would yield x ≈ z... and that x + y ≈ y, by left-identity, is equivalent to x + y ≈ z + y for z = 0#. And then your lemma follows by making the further identification y = x. So in that sense, it is 'just' (reducible to) a combination of cancellability and left-identity, and hence, maybe, not such an 'interesting' lemma? And if it is interesting enough to add to the library, then the generalisation to x + y ≈ y ⇒ x ≈ 0#, is surely the more 'useful' statement?

Thanks @jamesmckinna I get your point. But x + y ≈ y ⇒ x ≈ 0# is same as left identity is unique +-identityˡ-unique. We have it when we export AbelianGroupProperties. But if you think we should not have this lemma I can remove it. :)

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Nov 11, 2022

Thanks @Akshobhya1234

But x + y ≈ y ⇒ x ≈ 0# is same as left identity is unique +-identityˡ-unique. We have it when we export AbelianGroupProperties. But if you think we should not have this lemma I can remove it. :)

A very nice isolation of the essential property: so I would suggest then not to have your new lemma at all, but simply to instantiate that property at y = x at any point of use.

@Akshobhya1234
Copy link
Contributor Author

Thanks @Akshobhya1234

But x + y ≈ y ⇒ x ≈ 0# is same as left identity is unique +-identityˡ-unique. We have it when we export AbelianGroupProperties. But if you think we should not have this lemma I can remove it. :)

A very nice isolation of the essential property: so I would suggest then not to have your new lemma at all, but simply to instantiate that property at y = x at any point of use.

Hmm I like to keep it. It comes under "Basic properties" of ring in many papers. Let's wait to see what @MatthewDaggitt has to say.

@MatthewDaggitt
Copy link
Contributor

Hmm I like to keep it. It comes under "Basic properties" of ring in many papers. Let's wait to see what @MatthewDaggitt has to say.

Sorry for the late reply. I'm happy to keep the lemma, but I think @jamesmckinna is right in that it should definitely use the existing lemma to prove it, rather than reprove it from scratch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants