Skip to content

[ add ] rule of signs for RingWithoutOne #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jul 8, 2025

Surprised to find this was not anywhere in the library!
Warm-up for tackling #2704 , so could instead be folded into a PR for that, but this is of independent interest/importance?

Took the liberty of using the PR also to do some tidying up of the module... and to fix the markup in CHANGELOG

... prompting me to revisit #1875 : I'd still push for deprecating x+x≈x⇒x≈0 in favour of +-identityˡ-unique, otherwise if we think this lemma important enough, then perhaps it should be re-exported from where it's first definable, namely all the way up (down?) the hierarchy in Algebra.Loop.Properties...

@jamesmckinna jamesmckinna added this to the v2.3 milestone Jul 8, 2025
@jamesmckinna
Copy link
Contributor Author

A general point about Algebra.Properties.X vs. Algebra.Consequences.Setoid: should this lemma be in Properties.RingWithoutOne, or proved first in Consequences, for a longish list of hypotheses?

@JacquesCarette
Copy link
Contributor

A general point about Algebra.Properties.X vs. Algebra.Consequences.Setoid: should this lemma be in Properties.RingWithoutOne, or proved first in Consequences, for a longish list of hypotheses?

I'm thinking Properties.RingWithoutOne. The only reason I would put it in Consequences is if the proof uses a 'weird' set of properties that amounts to an algebra without a name that is unlikely to see much use if it were created.

@MatthewDaggitt MatthewDaggitt modified the milestones: v2.3, v2.4 Jul 17, 2025
@MatthewDaggitt
Copy link
Contributor

In the interest of getting a release out, I'm bumping this to v2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants