Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(autocomplete): remove duplicate md-input-name #11280

Closed
wants to merge 1 commit into from
Closed

docs(autocomplete): remove duplicate md-input-name #11280

wants to merge 1 commit into from

Conversation

raphass
Copy link

@raphass raphass commented May 14, 2018

docs(md-auto-complete): remove duplicate attribute description

the other occurrence happens on line 104

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The entry md-input-name appears twice on the component jsDoc.
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 14, 2018
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar
Copy link
Contributor

Thank you for your contribution! Please update your commit to follow the commit message guidelines.

@Splaktar Splaktar added this to the 1.1.10 milestone May 15, 2018
@Splaktar Splaktar self-assigned this May 15, 2018
@Splaktar Splaktar added type: docs in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs P4: minor Minor issues. May not be fixed without community contributions. labels May 15, 2018
@Splaktar Splaktar changed the title Duplicate md-input-name jsDoc removal autocomplete: remove duplicate md-input-name JSDoc May 15, 2018
@Splaktar Splaktar changed the title autocomplete: remove duplicate md-input-name JSDoc docs(autocomplete): remove duplicate md-input-name May 15, 2018
Splaktar added a commit that referenced this pull request May 18, 2018
- fix typos
- fix invalid types
- remove out of date TODO
- fix invalid comments
- add missing JSDoc
- add link to CSP

Closes #11280.
@Splaktar
Copy link
Contributor

Don't worry about updating the commit message. I've included this in #11287. Thanks again for pointing this out!

@Splaktar Splaktar closed this May 18, 2018
mmalerba pushed a commit that referenced this pull request May 22, 2018
- fix typos
- fix invalid types
- remove out of date TODO
- fix invalid comments
- add missing JSDoc
- add link to CSP

Closes #11280.
@Splaktar Splaktar removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label May 22, 2018
Splaktar added a commit that referenced this pull request Jul 31, 2018
- fix typos
- fix invalid types
- remove out of date TODO
- fix invalid comments
- add missing JSDoc
- add link to CSP

Closes #11280.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants