Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(virtualRepeat): clean up and clarify #11287

Merged
merged 1 commit into from
May 22, 2018
Merged

docs(virtualRepeat): clean up and clarify #11287

merged 1 commit into from
May 22, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Typos, missing explanations, out of date comments, etc.

Issue Number:
Closes #11280.

What is the new behavior?

  • fix typos
  • fix invalid types
  • remove out of date TODO
  • fix invalid comments
  • add missing JSDoc
  • add link to CSP

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

@Splaktar
docs(virtualRepeat): clean up and clarify
7b836ce 
- fix typos
- fix invalid types
- remove out of date TODO
- fix invalid comments
- add missing JSDoc
- add link to CSP

Closes #11280.
@Splaktar Splaktar added type: docs pr: merge ready This PR is ready for a caretaker to review P4: minor Minor issues. May not be fixed without community contributions. pr: merge safe labels May 18, 2018
@Splaktar Splaktar added this to the 1.1.10 milestone May 18, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 18, 2018
@Splaktar Splaktar mentioned this pull request May 18, 2018
Closed
3 tasks
@Splaktar Splaktar assigned mmalerba and unassigned tinayuangao May 19, 2018
@mmalerba mmalerba merged commit 6b3afbb into master May 22, 2018
@Splaktar Splaktar deleted the virtualRepeatDocsImprovements branch May 22, 2018 23:09
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
docs(virtualRepeat): clean up and clarify (#11287)
978fe81 
- fix typos
- fix invalid types
- remove out of date TODO
- fix invalid comments
- add missing JSDoc
- add link to CSP

Closes #11280.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mmalerba mmalerba

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Milestone
1.1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @googlebot @mmalerba @tinayuangao