Skip to content

chore(go): update go test matrix and clean up setup #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

rishav-karanjit
Copy link
Member

@rishav-karanjit rishav-karanjit commented Jul 16, 2025

Issue #, if available:

Description of changes:

  • Adds Go 1.24 for CI to run test on. Note: We support minimum 1.23 and latest is 1.24.
  • install_smithy_dafny_codegen_dependencies github actions runs Go installation for all the runtime but its only Go which needs this installation not all other language. So, remove Go installation from install_smithy_dafny_codegen_dependencies and put it in Go specific workflow only.
  • Add fail-fast=false so that workflow does not fail in all matrix for one flaky failure.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws aws deleted a comment from github-actions bot Jul 16, 2025
@aws aws deleted a comment from github-actions bot Jul 16, 2025
@rishav-karanjit rishav-karanjit marked this pull request as ready for review July 16, 2025 16:41
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner July 16, 2025 16:41
@rishav-karanjit rishav-karanjit merged commit 7dd705b into main Jul 16, 2025
96 of 98 checks passed
@rishav-karanjit rishav-karanjit deleted the rishav/testOnVariousGoVersion branch July 16, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants