Skip to content

chore(go): update go test matrix and clean up setup #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@ runs:
python -m pip install --upgrade black
python -m pip install --upgrade docformatter

- name: Install Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
shell: bash
run: |
go install golang.org/x/tools/cmd/goimports@latest

# Without this the if-dafny-at-least command includes "Downloading ..." output
- name: Arbitrary makefile target to force downloading Gradle
shell: bash
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/ci_test_go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ on:
jobs:
testGo:
strategy:
fail-fast: false
matrix:
library: [DynamoDbEncryption, TestVectors]
os: [ubuntu-22.04, macos-13]
go-version: ["1.23"]
go-version: ["1.23", "1.24"]
runs-on: ${{ matrix.os }}
permissions:
id-token: write
Expand Down Expand Up @@ -108,6 +109,11 @@ jobs:
- name: Install Smithy-Dafny codegen dependencies
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies

- name: Install Go imports
shell: bash
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Build ${{ matrix.library }} implementation
shell: bash
working-directory: ./${{ matrix.library }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci_test_java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ on:
jobs:
testJava:
strategy:
fail-fast: false
matrix:
library: [DynamoDbEncryption]
java-version: [8, 11, 16, 17]
Expand Down
Loading