This repository was archived by the owner on Jul 19, 2025. It is now read-only.
QUA-360: Add skip diff coverage method #152
Merged
+171
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillof
requested review from
a team,
f-moya and
dantevvp
and removed request for
a team
dantevvp
approved these changes
Jun 29, 2022
| end | ||
|
|
||
| response | ||
| receive_request(%w[pending success failure skipped error], :update_status) |
There was a problem hiding this comment.
Is there a reason to pass the call_method as a symbol instead of a string? I see that we convert it as a string later in the receive_request method
There was a problem hiding this comment.
Honestly, there isn't a strong reason. I just felt like it was more readable, but I'm open to change it if you don't feel the same about it
There was a problem hiding this comment.
I personally like it as a symbol. I associate symbols with methods better 👍
larkinscott
reviewed
Jun 29, 2022
| @@ -36,6 +36,7 @@ def self.load_services | |||
| issue | |||
| pull_request | |||
| pull_request_coverage | |||
There was a problem hiding this comment.
Just curious: is this the Actually, never mind.total_coverage event?
There was a problem hiding this comment.
Were you able to find out why this is requested?? It's the available services names, so you can call it like
service = CC::Service::GitHubPullRequests.new(
{
oauth_token: ...,
},
name: "pull_request_diff_coverage",
state: "skipped",
github_slug: ...,
number: ...,
commit_sha: ...
)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that we're implementing the ability to skip draft PRs reviews, we want to avoid the "waiting for status to be reported" situation on the diff and total coverage statuses, specifically when you configured them as a protection branch rule.
Changes
CC::PullRequestsclassRelated issue
https://codeclimate.atlassian.net/browse/QUA-360