Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

QUA-360: Separate diff and total coverage in different methods #154

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

camillof
Copy link
Contributor

@camillof camillof commented Jul 5, 2022

Context

Following #152 where we added a single method for skipping diff and total coverage, we realized that we may need them separated, to be called independently.

In addition to the skipped method, we also need the ability to set the pending status for bot total and diff coverage.

image

@@ -14,7 +14,11 @@ def receive_pull_request_coverage
end

def receive_pull_request_diff_coverage
receive_request("skipped", :update_diff_coverage_status)
receive_request(%w[pending skipped], :update_diff_coverage_status)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

receive_request(%w[pending skipped], :update_diff_coverage_status)
end

def receive_pull_request_total_coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@giordanoluzardo giordanoluzardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @camillof!

@camillof camillof merged commit a003dad into master Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants