Skip to content

Remove author from pubspec to silence pub complaints #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

Remove author from pubspec to silence pub complaints #2064

merged 1 commit into from
Nov 7, 2019

Conversation

jcollins-g
Copy link
Contributor

A new version of pub has a new warning. This fixes:

try-publish: |       '-- pubspec.yaml
try-publish: '-- tool
try-publish:     |-- after_failure_travis.sh
try-publish:     |-- builder.dart
try-publish:     |-- doc_packages.dart
try-publish:     |-- grind.dart
try-publish:     |-- install_travis.sh
try-publish:     '-- travis.sh
try-publish: Suggestions:
try-publish: * Your pubspec.yaml includes an "author" section which is no longer used and may be removed.
try-publish:
try-publish: Package has 1 warning.
ProcessException: SubprocessLauncher got non-zero exitCode: 65

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 7, 2019
@jcollins-g jcollins-g requested review from pq and devoncarew November 7, 2019 21:58
@jcollins-g
Copy link
Contributor Author

Going to force squash and merge because of bot trouble.

@jcollins-g jcollins-g merged commit 88c82b3 into master Nov 7, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.877% when pulling 8672854 on remove-author into 6cee315 on master.

jcollins-g added a commit that referenced this pull request Nov 8, 2019
@jcollins-g
Revert "Remove author because pub complains about it. (#2064)"
e138f5f 
This reverts commit 88c82b3.
jcollins-g added a commit that referenced this pull request Nov 8, 2019
@jcollins-g
Make publish test conditional on version (#2065)
5983455 
* Revert "Remove author because pub complains about it. (#2064)"

This reverts commit 88c82b3.

* select whether to run publish test based on version

* Disable for appveyor
@jcollins-g jcollins-g deleted the remove-author branch November 8, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@pq pq Awaiting requested review from pq

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @devoncarew @googlebot