Skip to content

Make publish test conditional on version #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2019
Merged

Make publish test conditional on version #2065

merged 3 commits into from
Nov 8, 2019

Conversation

jcollins-g
Copy link
Contributor

Removing author isn't allowed in stable, and having it gives warnings in dev. So run the publish test conditionally for now.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 8, 2019
@jcollins-g jcollins-g mentioned this pull request Nov 8, 2019
Merged
@coveralls
Copy link

coveralls commented Nov 8, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.877% when pulling 18fa5bb on fix-pubspec-stable into 88c82b3 on master.

@jcollins-g jcollins-g merged commit 5983455 into master Nov 8, 2019
@jcollins-g jcollins-g deleted the fix-pubspec-stable branch November 8, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @gspencergoog @googlebot