Simplify bundler config so "bundle install" does the right thing by default #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If/when this merges, I'll update |
|
I also wanted to do |
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Oct 20, 2014
Simplify bundler config so "bundle install" does the right thing by default
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 20, 2014
For details of the ruby and rails changes, see docker-library/ruby#21 and docker-library/rails#12.
chrissolanilla
pushed a commit
to chrissolanilla/CSolanillaBio
that referenced
this pull request
May 16, 2024
chrissolanilla
pushed a commit
to chrissolanilla/CSolanillaBio
that referenced
this pull request
May 16, 2024
added current year to copyright range. Will automatically update thanks to PHP. fixes docker-library#21 See merge request !15
chrissolanilla
pushed a commit
to chrissolanilla/CSolanillaBio
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes it so that when we
ONBUILD RUN bundle installit doesn't create.bundle/configin our precious, pristine application directory, and makes all the bundler-installed Gems show up ingem list.I'm also sneaking in a change to the
onbuildvariants that makesbundle installjust fail if you've updated yourGemfilebut not yourGemfile.lock, since that bit me pretty hard while testing this (ie,bundle installwas silently updatingGemfile.lock, which changes were then clobbered by theCOPY . /usr/src/appand the application wouldn't run). I think this might actually be the real issue in docker-library/rails#11, too.