Landing page improvements and general fixes #526
Conversation
mansona
force-pushed
the
landing-page-improvements
branch
from
702093e to
1657049
Compare
|
Looking good. I just saw these two issues in mobile:
Hover state on the tabs should also make it more visible that it's clickable. |
|
@josemarluedke thanks a million for checking this out! I'll get that fix in right away 🎉 |
mansona
force-pushed
the
landing-page-improvements
branch
from
bc59a96 to
652da3d
Compare
|
Files that got Bigger 🚨:
Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
|
@josemarluedke those are fixed now 👍 thanks again for noticing them! |
| class="addon-tabs--tab {{if (eq this.currentTab 2) "active-tab"}}" | ||
| onclick={{action (mut this.currentTab) 2}} | ||
| > | ||
| Percy |
There was a problem hiding this comment.
We should not include percy because it requires payment. There is another open source addon that does visual regression testing if you want to find and use that.
There was a problem hiding this comment.
They do have a quite generous free plan, though: https://percy.io/pricing . Up to 10 team members and 5000 snapshots/month.
| @@ -0,0 +1,4 @@ | |||
| <div class="ecosystem-icon"> | |||
| <svg class="background" xmlns="http://www.w3.org/2000/svg" width="133" height="130"><defs/><path fill={{@bg}} fill-rule="nonzero" d="M.91 27.535l15.047 93.176c.878 5.44 5.993 9.145 11.436 8.283l96.19-15.233c5.45-.863 9.172-5.98 8.314-11.43L117.264 9.301c-.857-5.451-5.969-9.178-11.42-8.326L9.238 16.06a10 10 0 00-8.33 11.475z"/></svg> | |||
| <img class="logo {{if @rotate "rotate"}}" src="/images/home/logos/{{@icon}}.svg" alt=""> | |||
There was a problem hiding this comment.
what is the SVG doing in this case?
the image needs valid alt text. Please turn on ember-template-lint if it is not already turned on- code shouldn't be making it this far with these type of basic errors.
There was a problem hiding this comment.
So the SVG is the background, it's an inline SVG so that we can pass the background fill colour in via the {{@bg}} attribute
There is an alt="" attribute so that's why it's not causing an error with the template lint. I thought that this is what you're supposed to do when something is presentational 😞I'm sorry for the mistake, I'll try to do better in future. I have made the alt be the same as the icon now.
Also I've made the changes over in this other PR because I'm splitting this one: #529
| <a href="https://blog.emberjs.com/2019/12/20/octane-is-here.html">Read the announcement</a> | ||
| </h3> | ||
| </EsCard> | ||
| <EsCard card-link> |
There was a problem hiding this comment.
what is the "card-link" part mean?
There was a problem hiding this comment.
This is documented in https://deploy-preview-145--ember-styleguide.netlify.com/components/card/ and is a way to enable the "stretch link" functionality described in https://inclusive-components.design/cards/
The commits on this one are pretty atomic so you can see exactly what is done there 👍
This is the last PR to make the website pretty much feature complete 🎉 😱 The remainder of the items in https://github.com/orgs/ember-learn/projects/16 are either performance related (and could possibly happen after launch) or are waiting for content of some kind
Fixes #459
Fixes #520
Fixes #368
I've also updated the styleguide so it fixes a bunch of SVG issues
Fixes ember-learn/ember-styleguide#266
Fixes ember-learn/ember-styleguide#268