-
-
Notifications
You must be signed in to change notification settings - Fork 191
Addon tabs component #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon tabs component #530
Conversation
Files that got Bigger 🚨:
Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this component into the styleguide. There are other use cases for tabs.
@@ -0,0 +1,6 @@ | |||
import Component from '@ember/component'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely be in the style guide addon.
@MelSumner I disagree that this should be in the styleguide 🙈 We can discuss it more on Thursday but I'll summarise it quickly here too. Since the last time that I tried to put this in the styleguide, I have been thinking a lot about this implementation and have even tried it out with a client's app. There is a lot to be desired when coming up with a truly generic implementation of Tabs that could work like this does and could be adapted for multiple places and my experimentation has not lead me to find something that is good enough to be universal yet. The implementation in this PR is not really generic enough to move into the styleguide and definitely doesn't have a good API for people to use. I would be very much against moving this to the styleguide with a promise of "other use cases for tabs" without first having an example of one of those use cases and building something that works for both cases. If we did it now I feel very strongly that it would be a big premature optimisation 🙈 |
I also see this more in the website repository than in the style guide for now. We can easily extract them from here and move them to the style guide later on. |
We want this component for other websites, which is why I think it should be in the styleguide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This makes the "Meet Addons" section image a real component with a tabbed UI and no longer just an image
Fixes #520