Skip to content

ci: Reorder reporters to prevent log message duplication #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

MarkDuckworth
Copy link
Contributor

Reorder reporters in karma config to prevent log message duplication. Currently in CI actions that run Karma, all SDK logging is rendered twice (example). This fixes the issue.

See also: karma-runner/karma#2342 (comment)

@MarkDuckworth MarkDuckworth requested a review from a team as a code owner May 14, 2025 18:50
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 6289324

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@MarkDuckworth MarkDuckworth changed the title chore: Reorder reporters to prevent log message duplication ci: Reorder reporters to prevent log message duplication May 14, 2025
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! This always bothered me but I was never able to find the source of it.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@dlarocque
Copy link
Contributor

ty!

@MarkDuckworth MarkDuckworth merged commit d5e5795 into main May 22, 2025
49 of 53 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/fix-duplicate-console-logging branch May 22, 2025 18:17
mansisampat added a commit that referenced this pull request Jun 17, 2025
* Version Packages (#9016)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Revert "Fixed scroll behavior (#8977)" (#9053)

* Revert "Fixed scroll behavior (#9043)"

This reverts commit 9bcd1ea.

* Revert "Add Emulator Overlay (#8977) (#9031)"

This reverts commit 8593fa0.

* Undid revert of util

* Create dirty-crews-cross.md

* Removed unnecessary markdown file

* Updated to only show banner when calling connect*Emulator (#9055)

* Version Packages (#9054)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Close webchannel instances on terminate (#9041)

Explicitly close any unclosed WebChannel instances on Firestore#terminate()

* Reorder reporters to prevent log message duplication in CI (#9040)

* docs(ai): Fix 'occured' typo in error codes (#9021)

* feat(ai): Add `HarmBlockThreshold.OFF` (#9050)

* feat(ai): Schema `title`, `maximum`, `minimum`, and `propertyOrdering` (#9047)

* feat(ai): Add support for `minItems` and `maxItems` to `Schema` (#9026)

* Build out e2e subdirectories (#9065)

* Added test project to fdc (#8924)

* Version Packages (#9073)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Release version 11.9.0.

* test(ai): add integration tests (#8853)

* Update issue template to rename VertexAI > AI (#9074)

* ci: Fix Firefox error and streamline cross-browser tests (#9015)

* Fixed issue where requestSts wasn't including the Studio cookie in it (#9075)

* Fix issue where we ping an endpoint that hasn't been implemented (#9059)

* Updated firebase auth changeset (#9088)

* build(all): Version Packages v11.9.1 (#9089)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

v11.9.1 release.

* test(ai): Upgrade mock responses to v14 (#9091)

---------

Co-authored-by: Google Open Source Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Maneesh Tewani <[email protected]>
Co-authored-by: Mark Duckworth <[email protected]>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: Christina Holland <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants