Skip to content

Fix issue where we ping an endpoint that hasn't been implemented #9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented May 23, 2025

When attempting to get cookies for the storage emulator in Firebase Studio, the endpoint returns with 501 because / hasn't been implemented. Instead, we should be calling /b.

@maneesht maneesht requested review from tonyjhuang and a team as code owners May 23, 2025 18:02
Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: 869a49e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 23, 2025

Size Report 1

Affected Products

  • @firebase/storage

    TypeBase (c0617a3)Merge (bc67dbd)Diff
    browser58.5 kB58.5 kB+2 B (+0.0%)
    main60.0 kB60.0 kB+2 B (+0.0%)
    module58.5 kB58.5 kB+2 B (+0.0%)
  • bundle

    TypeBase (c0617a3)Merge (bc67dbd)Diff
    storage (getBytes)47.2 kB47.2 kB+2 B (+0.0%)
    storage (getDownloadURL)49.2 kB49.2 kB+2 B (+0.0%)
    storage (getMetadata)48.7 kB48.7 kB+2 B (+0.0%)
    storage (list + listAll)48.1 kB48.1 kB+2 B (+0.0%)
    storage (updateMetadata)49.0 kB49.0 kB+2 B (+0.0%)
    storage (uploadBytes)53.8 kB53.8 kB+2 B (+0.0%)
    storage (uploadBytesResumable)63.8 kB63.8 kB+2 B (+0.0%)
    storage (uploadString)54.0 kB54.0 kB+2 B (+0.0%)
  • firebase

    TypeBase (c0617a3)Merge (bc67dbd)Diff
    firebase-compat.js802 kB802 kB+4 B (+0.0%)
    firebase-storage-compat.js44.2 kB44.2 kB+4 B (+0.0%)
    firebase-storage.js51.1 kB51.1 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dgKBWSF4Dn.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 23, 2025

Size Analysis Report 1

Affected Products

  • @firebase/storage

    • connectStorageEmulator

      Size

      TypeBase (c0617a3)Merge (bc67dbd)Diff
      size11.8 kB11.8 kB+2 B (+0.0%)
      size-with-ext-deps34.8 kB34.8 kB+2 B (+0.0%)
    • getStorage

      Size

      TypeBase (c0617a3)Merge (bc67dbd)Diff
      size12.0 kB12.0 kB+2 B (+0.0%)
      size-with-ext-deps42.7 kB42.7 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oyJqYa8pjV.html

@maneesht maneesht requested review from a team as code owners May 23, 2025 18:31
@maneesht maneesht merged commit 0f891d8 into main Jun 6, 2025
37 of 38 checks passed
@maneesht maneesht deleted the mtewani/fix-storage-emulator-changes branch June 6, 2025 17:17
@google-oss-bot google-oss-bot mentioned this pull request Jun 10, 2025
mansisampat added a commit that referenced this pull request Jun 17, 2025
* Version Packages (#9016)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Revert "Fixed scroll behavior (#8977)" (#9053)

* Revert "Fixed scroll behavior (#9043)"

This reverts commit 9bcd1ea.

* Revert "Add Emulator Overlay (#8977) (#9031)"

This reverts commit 8593fa0.

* Undid revert of util

* Create dirty-crews-cross.md

* Removed unnecessary markdown file

* Updated to only show banner when calling connect*Emulator (#9055)

* Version Packages (#9054)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Close webchannel instances on terminate (#9041)

Explicitly close any unclosed WebChannel instances on Firestore#terminate()

* Reorder reporters to prevent log message duplication in CI (#9040)

* docs(ai): Fix 'occured' typo in error codes (#9021)

* feat(ai): Add `HarmBlockThreshold.OFF` (#9050)

* feat(ai): Schema `title`, `maximum`, `minimum`, and `propertyOrdering` (#9047)

* feat(ai): Add support for `minItems` and `maxItems` to `Schema` (#9026)

* Build out e2e subdirectories (#9065)

* Added test project to fdc (#8924)

* Version Packages (#9073)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Release version 11.9.0.

* test(ai): add integration tests (#8853)

* Update issue template to rename VertexAI > AI (#9074)

* ci: Fix Firefox error and streamline cross-browser tests (#9015)

* Fixed issue where requestSts wasn't including the Studio cookie in it (#9075)

* Fix issue where we ping an endpoint that hasn't been implemented (#9059)

* Updated firebase auth changeset (#9088)

* build(all): Version Packages v11.9.1 (#9089)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

v11.9.1 release.

* test(ai): Upgrade mock responses to v14 (#9091)

---------

Co-authored-by: Google Open Source Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Maneesh Tewani <[email protected]>
Co-authored-by: Mark Duckworth <[email protected]>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: Christina Holland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants