This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Change the directory to the scenario app #17583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Apr 8, 2020
|
I’m not sure what broke it. I’m also not sure why the check is passing even though it failed to build the APK. |
|
The check was made to always pass because of flakiness with the GCP python
installation.
…On Wed, Apr 8, 2020 at 8:41 AM Emmanuel Garcia ***@***.***> wrote:
I’m not sure what broke it. I’m also not sure why the check is passing
even though it failed to build the APK.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#17583 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBYVRMEB3ALYYD3EWHSAHTRLSLKXANCNFSM4MDT2WUA>
.
|
|
Even the build scenario app step? |
|
Ah! no, that should fail. The script needs an update. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2020
This was referenced Apr 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change might fix the issue in the log: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8883634725340095856/+/steps/Build_scenario_app/0/stdout?format=raw.
See:
Could not find a file named "pubspec.yaml" in "/b/s/w/ir/cache/builder/src".