set -e on assemble_apk.sh #17588
set -e on assemble_apk.sh #17588
Conversation
| ./flutter/tools/gn --unopt | ||
| ninja -C out/host_debug_unopt sky_engine sky_services |
There was a problem hiding this comment.
@blasten - I believe this is a better fix than changing the pubspec, since we have other modes that want to run jit and need debug mode built. The expectation is that everyone runs at least this for host_debug_unopt (it's a pretty fast build step, just involves copying/repackaging dart files).
There was a problem hiding this comment.
Is there any benefit in doing this step in the LUCI recipe before assemble_apk.sh is invoked?
There was a problem hiding this comment.
At some point that's how it worked I think. The danger is that someone "fixes" the recipe without realizing its breaking this script - this also lets the script run locally.
If this was doing actual C compilation it could be a problem too, because you have to make sure goma is available/running and LUCI likes to handle that special, but it should be fine here. These tasks just copy dart files around.
dnfield
added
the
waiting for tree to go green
* set -e on assemble_apk.sh * build the necessary artifacts
Without this, CI will incorrectly think that the script has succeeded even if a sub-invocation failed.
Additional context at #17583