This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update GLFW embedding to support AOT mode #18423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jonahwilliams
approved these changes
May 27, 2020
stuartmorgan-g
suggested changes
May 27, 2020
stuartmorgan-g
suggested changes
May 28, 2020
shell/platform/glfw/client_wrapper/include/flutter/flutter_window_controller.h
Show resolved
Hide resolved
shell/platform/glfw/client_wrapper/include/flutter/flutter_window_controller.h
Outdated
Show resolved
Hide resolved
shell/platform/glfw/client_wrapper/include/flutter/flutter_window_controller.h
Outdated
Show resolved
Hide resolved
stuartmorgan-g
added
the
waiting for tree to go green
stuartmorgan-g
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks: flutter/flutter#57135
Together with the above version of flutter tool, one can test this by building and running any application in profile or release mode like so:
flutter --local-engine=host_profile_unopt build linux --profileor
flutter --local-engine=host_release_unopt build linux --release